Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: Transport returns flow control too quickly #61681

Closed
neild opened this issue Jul 31, 2023 · 2 comments
Closed

x/net/http2: Transport returns flow control too quickly #61681

neild opened this issue Jul 31, 2023 · 2 comments
Assignees
@neild
Labels
FrozenDueToAge

Comments

@neild
Copy link
Contributor

neild commented Jul 31, 2023

The HTTP/2 transport returns flow control credit for stream data immediately upon processing the DATA frame. It should return flow control when the user reads the data, to avoid buffering arbitrarily large amounts of data that the user isn't reading.
@neild
Copy link
Contributor Author

neild commented Jul 31, 2023

...wait, that's not what it's doing. (That didn't seem right...) I've got something else wrong in this test. Digging further.

@neild neild self-assigned this Jul 31, 2023
@neild
Copy link
Contributor Author

neild commented Jul 31, 2023

Yep, ignore me.

@neild neild closed this as completed Jul 31, 2023
@neild neild closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
@golang golang locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@neild neild

Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neild @gopherbot