Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove double space in "func" snippets #61660

Closed
mochamadhaikal opened this issue Jul 31, 2023 · 4 comments
Closed

x/tools/gopls: remove double space in "func" snippets #61660

mochamadhaikal opened this issue Jul 31, 2023 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unplanned

Comments

@mochamadhaikal
Copy link

I don't feel comfortable with this "func" snippet. it has 2 spaces before the opening curly brace
Screen Shot 2023-07-31 at 10 59 18
Maybe the "go" creators can change this馃檹馃徔馃檹馃徔
@seankhliao seankhliao changed the title minor changes to "func" snippets x/tools/gopls: minor changes to "func" snippets Jul 31, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 31, 2023
@seankhliao seankhliao removed gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. pkgsite labels Jul 31, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 31, 2023
@seankhliao seankhliao added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Jul 31, 2023
@seankhliao seankhliao changed the title x/tools/gopls: minor changes to "func" snippets x/tools/gopls: remove double space in "func" snippets Jul 31, 2023
@findleyr
Copy link
Contributor

Thanks, this is a bug. We'll fix in the next patch release.

@findleyr
Copy link
Contributor

Sorry, looking at your screenshot again, I'm not sure this is a bug. It looks like there's a tabstop to write the result type.

Also, I don't think this is a gopls snippet. Looks like it may be a VS Code snippet?

@findleyr
Copy link
Contributor

Closing this as WAI, since this isn't actionable for gopls.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
@findleyr findleyr modified the milestones: gopls/v0.13.2, Unplanned Aug 11, 2023
@mochamadhaikal
Copy link
Author

yes, it's in vscode. sorry, looks like it's a go extension error in vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@gopherbot @seankhliao @findleyr @mochamadhaikal