cmd/go: in go 1.21 module, go mod tidy and 'go list -m -u all' disagree over which go.sum lines are needed #61605

dmitshur · 2023-07-27T05:11:22Z

What version of Go are you using (`go version`)?

$ go version
go version go1.21rc3 darwin/arm64

Does this issue reproduce with the latest release?

No(-ish).

I first ran into this in a module whose 'go' line is 1.21, so the latest release today (1.20.6) isn't applicable.

If I change the 'go' line to 1.20, then 'go mod tidy' no longer deletes as many go.sum lines, and the issue doesn't reproduce.

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/gopher/Library/Caches/go-build'
GOENV='/Users/gopher/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT='loopvar'
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/gopher/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/gopher/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21rc3'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/_0/h0671fcn4rgb5pn9c745dx2h0000gn/T/go-build1549452710=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

I ran go mod tidy in a medium sized local module whose go.mod has 'go 1.21' (primarily to help test this language version and its semantics, not because I need it; this go.mod file isn't public).

Then I ran go list -m -u all.

Edit: It turned out trivial to trigger the issue with a very minified top-level go.mod file. Here's a complete reproducer:

$ cd $(mktemp -d)
$ go mod init issue61605.test
$ echo 'package p; import _ "golang.org/x/build/maintner/reclog"' > p.go
$ go get golang.org/x/build@v0.0.0-20230726111318-84c18c56e0b0
$ go mod tidy
$ go list -m -u all

What did you expect to see?

The usual list of modules and available updates, and exit code 0.

What did you see instead?

$ go list -m -u all
go: updates to go.sum needed, disabled by -mod=readonly
$ echo $?
1

Running the go list command with -mod=mod re-adds the go.sum lines and makes the command work.

Or setting go to 1.20 instead of 1.21 and re-running go mod tidy also works around the issue.

The text was updated successfully, but these errors were encountered:

dmitshur · 2023-07-27T14:32:32Z

CC @bcmills, @matloob.

rsc · 2023-07-27T19:47:36Z

Here's a test case version. I have not managed to whittle it down but I think I see a way to make it stop breaking (not the right way, but a way).

[!net:golang.org] skip

env GOPROXY=https://proxy.golang.org/
env GOSUMDB=

! go list
stderr 'missing go.sum entry'
go mod tidy
go list all
cat go.sum

go list -m -u
cat go.sum

go list -m -u all
cat go.sum

go list -mod=mod -m -u
cat go.sum

go list -mod=mod -m -u all
cat go.sum
stdout xxx

-- go.mod --
module m
require golang.org/x/build v0.0.0-20230726111318-84c18c56e0b0

-- x.go --
package p; import _ "golang.org/x/build/maintner/reclog"

gopherbot · 2023-07-27T20:00:07Z

Change https://go.dev/cl/513778 mentions this issue: cmd/go: make go list -m -u all not complain about missing checksums

rsc · 2023-07-27T20:00:30Z

After CL 513778 is submitted to the Go 1.21 release branch, we can move this to the Go 1.22 milestone.

This is a band-aid of a fix for Go 1.21, to create space to work on a real fix for Go 1.22, if in fact the real fix is different. It simply disables the go.sum update check during go list -m -u. I don't have a self-contained test for the breakage. See #61605. All existing tests continue to pass. For #61605. After merging into the Go 1.21 branch we can move #61605 to the Go 1.22 milestone. Change-Id: Ib155710092003f08d2a6ce0aefa8e0270cad5a5c Reviewed-on: https://go-review.googlesource.com/c/go/+/513778 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>

gopherbot · 2023-08-01T18:23:31Z

Change https://go.dev/cl/514899 mentions this issue: [release-branch.go1.21] cmd/go: make go list -m -u all not complain about missing checksums

rsc · 2023-08-01T18:41:08Z

Submitted the band-aid to the Go 1.21 release branch. Now a Go 1.22 bug.

…bout missing checksums This is a band-aid of a fix for Go 1.21, to create space to work on a real fix for Go 1.22, if in fact the real fix is different. It simply disables the go.sum update check during go list -m -u. I don't have a self-contained test for the breakage. See #61605. All existing tests continue to pass. For #61605. After merging into the Go 1.21 branch we can move #61605 to the Go 1.22 milestone. Change-Id: Ib155710092003f08d2a6ce0aefa8e0270cad5a5c Reviewed-on: https://go-review.googlesource.com/c/go/+/514899 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

…bout missing checksums This is a band-aid of a fix for Go 1.21, to create space to work on a real fix for Go 1.22, if in fact the real fix is different. It simply disables the go.sum update check during go list -m -u. I don't have a self-contained test for the breakage. See golang#61605. All existing tests continue to pass. For golang#61605. After merging into the Go 1.21 branch we can move golang#61605 to the Go 1.22 milestone. Change-Id: Ib155710092003f08d2a6ce0aefa8e0270cad5a5c Reviewed-on: https://go-review.googlesource.com/c/go/+/514899 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

bcmills · 2023-08-08T01:52:13Z

I think a proper fix is in the general direction of #40775. The set of checksums to retain should be associated with the modload.Requirements struct in some way rather than tracked as a global variable.

bcmills · 2024-03-14T21:14:41Z

@matloob, @samthanawalla: this is a code cleanup needed in cmd/go. I expect that a proper solution to it will be fairly involved; there is an unfortunate amount of communication through global variables in the code that updates the go.sum file.

dmitshur added GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 27, 2023

heschi added the release-blocker label Jul 27, 2023

dmitshur added this to the Go1.21 milestone Jul 27, 2023

rsc modified the milestones: Go1.21, Go1.22 Aug 1, 2023

bcmills self-assigned this Aug 8, 2023

jeffpignataro added a commit to jeffpignataro/golang that referenced this issue Sep 3, 2023

Had to downgrade because of 1.21 bug golang/go#61605

f593239

cherrymui removed the release-blocker label Sep 6, 2023

bcmills modified the milestones: Go1.22, Go1.23 Feb 1, 2024

bcmills removed their assignment Mar 14, 2024

matloob self-assigned this Apr 2, 2024

matloob modified the milestones: Go1.23, Go1.24 Apr 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go: in go 1.21 module, go mod tidy and 'go list -m -u all' disagree over which go.sum lines are needed #61605

cmd/go: in go 1.21 module, go mod tidy and 'go list -m -u all' disagree over which go.sum lines are needed #61605

dmitshur commented Jul 27, 2023 •

edited

dmitshur commented Jul 27, 2023

rsc commented Jul 27, 2023

gopherbot commented Jul 27, 2023

rsc commented Jul 27, 2023

gopherbot commented Aug 1, 2023

rsc commented Aug 1, 2023

bcmills commented Aug 8, 2023

bcmills commented Mar 14, 2024

cmd/go: in go 1.21 module, go mod tidy and 'go list -m -u all' disagree over which go.sum lines are needed #61605

cmd/go: in go 1.21 module, go mod tidy and 'go list -m -u all' disagree over which go.sum lines are needed #61605

Comments

dmitshur commented Jul 27, 2023 • edited

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

dmitshur commented Jul 27, 2023

rsc commented Jul 27, 2023

gopherbot commented Jul 27, 2023

rsc commented Jul 27, 2023

gopherbot commented Aug 1, 2023

rsc commented Aug 1, 2023

bcmills commented Aug 8, 2023

bcmills commented Mar 14, 2024

dmitshur commented Jul 27, 2023 •

edited

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?