Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/doc: Synopsis returns a sentence fragment rather than a sentence #6160

Closed
kortschak opened this issue Aug 16, 2013 · 3 comments
Closed

go/doc: Synopsis returns a sentence fragment rather than a sentence #6160

kortschak opened this issue Aug 16, 2013 · 3 comments
Milestone

Comments

@kortschak
Copy link
Contributor

In revision 96fefaa02ae3 the behaviour of Synopsis was changed to break on
":\n". This means that the comment for Synopsis is now incorrect wrt
definition of the string end point (in addition to the returned string not being a
sentence):

// Synopsis returns a cleaned version of the first sentence in s.
// That sentence ends after the first period followed by space and
// not preceded by exactly one uppercase letter. The result string
// has no \n, \r, or \t characters and uses only single spaces between
// words. If s starts with any of the IllegalPrefixes, the result
// is the empty string.
@robpike
Copy link
Contributor

robpike commented Aug 16, 2013

Comment 1:

Yeah, I think we should just revert that CL.

Labels changed: added priority-soon, go1.2, removed priority-triage, go1.2maybe.

Status changed to Accepted.

@robpike
Copy link
Contributor

robpike commented Aug 16, 2013

Comment 2:

Owner changed to @dsymonds.

@dsymonds
Copy link
Contributor

Comment 3:

This issue was closed by revision ea6cfc5.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants