Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/signal: TestTerminalSignal failures with subprogram failed: exit status 1 after Waiting for exit... #61595

Open
gopherbot opened this issue Jul 26, 2023 · 4 comments
Open

os/signal: TestTerminalSignal failures with subprogram failed: exit status 1 after Waiting for exit... #61595

gopherbot opened this issue Jul 26, 2023 · 4 comments
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented Jul 26, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "os/signal" && test == "TestTerminalSignal" && `Waiting for exit` && `subprogram failed: exit status 1`

Issue created automatically to collect these failures.

Example (log):

error running second subprocess: <nil>
--- FAIL: TestTerminalSignal (90.76s)
    signal_cgo_test.go:186: Sending ^Z...
    signal_cgo_test.go:198: Sending SIGCONT...
    signal_cgo_test.go:211: Waiting for exit...
    signal_cgo_test.go:214: subprogram failed: exit status 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 26, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/signal" && test == "TestTerminalSignal"
2023-07-26 15:13 darwin-amd64-12_0 go@f0894a00 os/signal.TestTerminalSignal (log) 
error running second subprocess: <nil>
--- FAIL: TestTerminalSignal (90.76s)
    signal_cgo_test.go:186: Sending ^Z...
    signal_cgo_test.go:198: Sending SIGCONT...
    signal_cgo_test.go:211: Waiting for exit...
    signal_cgo_test.go:214: subprogram failed: exit status 1

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 26, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 26, 2023

See previously:

But the failure mode here is different. (Possibly related to the macOS cluster in #54461 (comment)?)

@bcmills bcmills mentioned this issue Jul 26, 2023
Open
@bcmills bcmills changed the title os/signal: TestTerminalSignal failures os/signal: TestTerminalSignal failures with subprogram failed: exit status 1 after Waiting for exit... Jul 26, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 26, 2023

This does look like a possible match for the timeout failures in #37329 (comment), though. 🤔

@mknyszek mknyszek added this to the Backlog milestone Aug 2, 2023
@mknyszek mknyszek self-assigned this Aug 2, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 8, 2023 •
edited

@mknyszek, note that the failures in #37329 (comment) were all on the darwin-amd64-12_0 builder.

It is possible that this is a kernel bug in that specific macOS release. If that appears to be the case, you may want to consider adding a skip for the test based on the OS or kernel version, or (less ideally but perhaps easier to implement) based on testenv.Builder() != "darwin-amd64-12_0".

@bcmills bcmills mentioned this issue Nov 3, 2023
Open
@bcmills bcmills mentioned this issue Dec 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
Go Compiler / Runtime
Status: Todo
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot