Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove convenience analyzers (cleanup) #61559

Closed
findleyr opened this issue Jul 25, 2023 · 4 comments
Closed

x/tools/gopls: remove convenience analyzers (cleanup) #61559

findleyr opened this issue Jul 25, 2023 · 4 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

Reminder issue: CL 511995 left now-pointless shells for "convenience analyzers", which were refactored to be computed outside of the analysis framework.

We should clean up, though doing so will mean that these analyzers are no longer configurable via the "analyses" setting. That's probably fine; if necessary we can introduce a new way to configure refactorings, but I'd rather not do that if unnecessary.
@findleyr findleyr added this to the gopls/v0.13.0 milestone Jul 25, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 25, 2023
@adonovan
Copy link
Member

Didn't you do this already?

@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.15.0 Oct 9, 2023
@gopherbot
Copy link

Change https://go.dev/cl/537155 mentions this issue: gopls/internal/lsp: eliminate "convenience" analyzers

@findleyr findleyr mentioned this issue Oct 24, 2023
Closed
@findleyr
Copy link
Contributor Author

As you noted in your CL, we need to decide what to do with configuration.

I think we can honor the old configuration for a release or two, and then remove it. I don't think there's a strong reason to make code actions configurable, since they are much less intrusive than diagnostics.

@hyangah hyangah mentioned this issue Oct 30, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/556555 mentions this issue: gopls: consolidate analyzers, eliminating "convenience" analyzers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr