Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/fetch: TestExtractReadmes failures #61556

Closed
gopherbot opened this issue Jul 24, 2023 · 3 comments
Closed

x/pkgsite/internal/fetch: TestExtractReadmes failures #61556

gopherbot opened this issue Jul 24, 2023 · 3 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
pkgsite/backlog

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/fetch" && test == "TestExtractReadmes"

Issue created automatically to collect these failures.

Example (log):

2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetterwork_dir3481770641/001 in 197.766832ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGettermodule_dir1639853321/001/foo in 194.689897ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetternested_package_dir1732045019/001/foo/foolog in 203.872406ms
2023/07/24 13:34:08 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetter_Invalidation1194617697/001 in 5.094307618s
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/basic") => (raw="v1.1.0" cooked="v1.1.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/retractions") => (raw="v1.2.0" cooked="v1.0.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("std") => (raw="v1.21.0" cooked="v1.21.0", <nil>)
--- FAIL: TestExtractReadmes (30.04s)
    --- FAIL: TestExtractReadmes/prefer_README.md (0.02s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/prefer_readme.markdown (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/no_readme (0.01s)
        readme_test.go:121: proxy.Client.Zip(ctx, "emp.ty/module", "v1.0.0"): Client.readBody("emp.ty/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/readme_is_a_directory (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 24, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/fetch" && test == "TestExtractReadmes"
2023-07-24 20:30 darwin-amd64-12_0 pkgsite@0bc4b0e9 go@bd3a1f24 x/pkgsite/internal/fetch.TestExtractReadmes (log) 
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:33:46 Info: unk/LICENSE.md license coverage too low ({Percent:0 Match:[]}), skipping
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: licenses.Detector.paths: open .: file does not exist
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetterwork_dir3481770641/001 in 197.766832ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGettermodule_dir1639853321/001/foo in 194.689897ms
2023/07/24 13:34:00 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetternested_package_dir1732045019/001/foo/foolog in 203.872406ms
2023/07/24 13:34:08 Info: go/packages.Load(["all"]) loaded 2 packages from /tmp/buildlet/tmp/TestGoPackagesModuleGetter_Invalidation1194617697/001 in 5.094307618s
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/basic") => (raw="v1.1.0" cooked="v1.1.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("example.com/retractions") => (raw="v1.2.0" cooked="v1.0.0", <nil>)
2023/07/24 13:34:09 Debug: LatestModuleVersions("std") => (raw="v1.21.0" cooked="v1.21.0", <nil>)
--- FAIL: TestExtractReadmes (30.04s)
    --- FAIL: TestExtractReadmes/prefer_README.md (0.02s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49451/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/prefer_readme.markdown (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49452/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/no_readme (0.01s)
        readme_test.go:121: proxy.Client.Zip(ctx, "emp.ty/module", "v1.0.0"): Client.readBody("emp.ty/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49453/emp.ty/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out
    --- FAIL: TestExtractReadmes/readme_is_a_directory (0.00s)
        readme_test.go:121: proxy.Client.Zip(ctx, "github.com/my/module", "v1.0.0"): Client.readBody("github.com/my/module", "v1.0.0", "zip"): executeRequest(ctx, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): ctxhttp.Do(ctx, client, "https://127.0.0.1:49454/github.com/my/module/@v/v1.0.0.zip"): context deadline exceeded: proxy timed out

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Jul 24, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. pkgsite labels Jul 25, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 25, 2023

Looks like this is caused by an unnecessary hard-coded timeout:
https://cs.opensource.google/go/x/pkgsite/+/master:internal/fetch/readme_test.go;l=24-25;drc=64dbd74b14032a5f58252a47fd85377381f3610f

(CC @matloob)

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 25, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 25, 2023
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Jul 26, 2023
@bcmills bcmills self-assigned this Aug 22, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 31, 2023

Fixed in https://go.dev/cl/521837.

@bcmills bcmills closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
pkgsite/backlog
Development

No branches or pull requests
3 participants
@hyangah @bcmills @gopherbot