Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cache: TestParseCache failures #61550

Closed
gopherbot opened this issue Jul 24, 2023 · 5 comments
Closed

x/tools/gopls/internal/lsp/cache: TestParseCache failures #61550

gopherbot opened this issue Jul 24, 2023 · 5 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.13.0

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == "TestParseCache"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestParseCache (0.00s)
    parse_cache_test.go:79: parseFiles("file:///myfile"): unexpected cache hit after overwriting cache

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 24, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == "TestParseCache"
2023-07-24 14:45 windows-arm64-11 tools@4f747866 go@7141d1e6 x/tools/gopls/internal/lsp/cache.TestParseCache (log) 
--- FAIL: TestParseCache (0.00s)
    parse_cache_test.go:79: parseFiles("file:///myfile"): unexpected cache hit after overwriting cache

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 24, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 24, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == "TestParseCache"
2023-07-24 14:45 windows-arm64-11 tools@4f747866 go@7141d1e6 x/tools/gopls/internal/lsp/cache.TestParseCache (log) 
--- FAIL: TestParseCache (0.00s)
    parse_cache_test.go:79: parseFiles("file:///myfile"): unexpected cache hit after overwriting cache

— watchflakes

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.5 Jul 24, 2023
@findleyr
Copy link
Contributor

Ack, I was aware of this race in the back of my mind, but forgot to avoid it. Fix incoming...

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 24, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 24, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/512635 mentions this issue: gopls/internal/lsp/cache: fix boundary cond in parseCache age eviction

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == "TestParseCache"
2023-07-24 16:39 windows-arm64-11 tools@478577b8 go@7141d1e6 x/tools/gopls/internal/lsp/cache.TestParseCache (log) 
--- FAIL: TestParseCache (0.00s)
    parse_cache_test.go:79: parseFiles("file:///myfile"): unexpected cache hit after overwriting cache

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.13.0
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr