Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: log/slog: Record.Attrs should return a bool for iterators #61539

Closed
seankhliao opened this issue Jul 23, 2023 · 2 comments
Closed

proposal: log/slog: Record.Attrs should return a bool for iterators #61539

seankhliao opened this issue Jul 23, 2023 · 2 comments
Labels
Proposal
Milestone
Proposal

Comments

@seankhliao
Copy link
Member

given the syntax in #61405, the only thing missing from making log/slog.Record.Attrs an iterator is the bool return, perhaps we should preemptively add it?

cc @jba @rsc
@gopherbot gopherbot added this to the Proposal milestone Jul 23, 2023
@AndrewHarrisSPU

This comment was marked as resolved.

Sign in to view
@seankhliao seankhliao changed the title proposal: log/slog: Record.Attrs should return a book for iterators proposal: log/slog: Record.Attrs should return a bool for iterators Jul 23, 2023
@rsc
Copy link
Contributor

rsc commented Jul 24, 2023

Or perhaps #61405 will drop the bool. It is looking that way.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
4 participants
@rsc @gopherbot @seankhliao @AndrewHarrisSPU