Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestIssue4191_InfiniteGetToPutTimeout failures with timeouts #61497

Open
gopherbot opened this issue Jul 21, 2023 · 2 comments
Open

net/http: TestIssue4191_InfiniteGetToPutTimeout failures with timeouts #61497

gopherbot opened this issue Jul 21, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented Jul 21, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestIssue4191_InfiniteGetToPutTimeout" && `increasing timeout` && `Error issuing GET`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.00s)
    --- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (2.44s)
        transport_test.go:2289: increasing timeout
        transport_test.go:2294: Error issuing GET: Get "http://127.0.0.1:58443/get": read tcp 127.0.0.1:58441->127.0.0.1:58443: i/o timeout

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 21, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestIssue4191_InfiniteGetToPutTimeout"
2023-07-21 05:26 netbsd-arm-bsiegert go@b104a0ef net/http.TestIssue4191_InfiniteGetToPutTimeout (log) 
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.00s)
    --- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (2.44s)
        transport_test.go:2289: increasing timeout
        transport_test.go:2294: Error issuing GET: Get "http://127.0.0.1:58443/get": read tcp 127.0.0.1:58441->127.0.0.1:58443: i/o timeout

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jul 21, 2023

(attn @neild)

It looks like the test only tries increasing the timeout once, from a hard-coded 100ms to a hard-coded 1s.
It seems to me that if the test machine is slow enough (or loaded heavily enough), even that 1s timeout may be too short.

@bcmills bcmills added this to the Backlog milestone Jul 21, 2023
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 21, 2023
@bcmills bcmills changed the title net/http: TestIssue4191_InfiniteGetToPutTimeout failures net/http: TestIssue4191_InfiniteGetToPutTimeout failures with timeouts Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot