Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: panic: builtins.go: assertion failed [1.21 backport] #61492

Closed
gopherbot opened this issue Jul 21, 2023 · 2 comments
Closed

cmd/compile: internal compiler error: panic: builtins.go: assertion failed [1.21 backport] #61492

gopherbot opened this issue Jul 21, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. release-blocker
Milestone
Go1.21

Comments

@gopherbot
Copy link

@mdempsky requested issue #61486 to be considered for backport to the next 1.21 minor release.

@gopherbot Please backport to Go 1.21. As @griesemer mentions, "It's not critical as this is somewhat unusual code, but at the same time this fixes a real bug and the fix is very specific to min/max only, which is new functionality. So it's not going to break existing code."
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 21, 2023
@gopherbot gopherbot mentioned this issue Jul 21, 2023
Closed
@mdempsky mdempsky added this to the Go1.21 milestone Jul 21, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 21, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/511857 mentions this issue: [release-branch.go1.21] go/types, types2: a min/max value argument must not be untyped

@gopherbot
Copy link
Author

Closed by merging 2fabb14 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Jul 21, 2023
@griesemer
[release-branch.go1.21] go/types, types2: a min/max value argument mu…
2fabb14 
…st not be untyped

Fizes #61492.

Change-Id: I5770e238e44b724816894d914b3ea5dc78bc3ced
Reviewed-on: https://go-review.googlesource.com/c/go/+/511835
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/511857
Reviewed-by: Cherry Mui <cherryyz@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Aug 2, 2023
@griesemer @bradfitz
[release-branch.go1.21] go/types, types2: a min/max value argument mu…
a768fd0 
…st not be untyped

Fizes golang#61492.

Change-Id: I5770e238e44b724816894d914b3ea5dc78bc3ced
Reviewed-on: https://go-review.googlesource.com/c/go/+/511835
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/511857
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. release-blocker
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@mdempsky @dmitshur @gopherbot