(attn @golang/windows)

Can you provide some more debugging detail?

If you modify the test to add a time.Sleep(10 * time.Minute) before that t.Fatal, can you see the GoSymbolicLinkTestShare share in, say, Windows Explorer?

Does the same test pass using go1.20.6?

(attn @golang/windows)

Can you provide some more debugging detail?

If you modify the test to add a time.Sleep(10 * time.Minute) before that t.Fatal, can you see the GoSymbolicLinkTestShare share in, say, Windows Explorer?

Execute net share to see

GoSymbolicLinkTestShare
             D:\TEMP\TestNetworkSymbolicLink514216218\001\GoSymbolicLinkTestShare

add a time.Sleep(10 * time.Minute) before that t.Fatal.

go test -timeout=10000s
--- FAIL: TestNetworkSymbolicLink (600.13s)
    os_windows_test.go:494: CreateFile \\localhost\GoSymbolicLinkTestShare\: The network path was not found.
FAIL
exit status 1
FAIL    os      607.942s

Thanks. Does that test pass using go1.20.6 and go1.19.11 (or a build from source on their respective release branches)?

I wonder if this may be related to https://go.dev/cl/460595.

That error message comes from ERROR_BAD_NETPATH. Unfortunately I can't easily investigate the problem because this test does not run on the Go project's gomote servers:

gopher@GOLANG-BUILDLET C:\workdir\go\src>..\bin\go test os -run=TestNetworkSymbolicLink -v
=== RUN   TestNetworkSymbolicLink
    os_windows_test.go:473: The Server service is not started.
--- SKIP: TestNetworkSymbolicLink (0.00s)
PASS
ok      os      0.029s

@qmuntal, do you have the bandwidth to look into this?

Change https://go.dev/cl/512075 mentions this issue: os: fix TestNetworkSymbolicLink

@qiulaidongfeng, does anything about the test change if you patch in https://go.dev/cl/512075?

In particular I wonder if we need to set ACCESS_READ in the SHARE_INFO_2 struct at creation time in order for CreateFile to be able to access the share.

I'm not able to get the test to run without skipping even when running it as an administrator on a local device. 🤯

I finally got my settings sorted out so that the test will run. It passes at HEAD for me.
@qiulaidongfeng, perhaps you have some kind of firewall preventing the test from working?

@bcmills I obtained CL 512075 and found that https://github.com/golang/go/blob/master/src/os/os_windows_test.go#L484 Change to UNCPath:=shareName+"\" , and the test will pass on my computer.

That would not be a UNC path — it would no longer be testing the property it aims to test.

I still suspect that this has something to do with a system-specific firewall setting or network-security hook. Since neither I nor @qmuntal are able to reproduce this failure mode and we don't have a specific theory of what could cause it, I am not able to investigate further.

I wonder if it also depends on some specific combination of SMBv1, SMBv2, and/or SMBv3 support (see https://learn.microsoft.com/en-us/windows-server/storage/file-server/troubleshoot/detect-enable-and-disable-smbv1-v2-v3?tabs=server).

Moving to Unplanned since we don't have any apparent way to move forward, and since getting the test to run in the first place — let alone fail! — seems to require a lot of fairly unusual factors (running the test as an administrator, having the service running, and so on).

@qiulaidongfeng, please let us know if you figure out more about what may be causing this test to fail in your setup.

Change https://go.dev/cl/512736 mentions this issue: os: fix test failure when SMB is not enabled

After enabling SMB, the test passed, and I sent CL 512736 to fix the failure when SMB was not enabled.

After enabling SMB, the test passed, and I sent CL 512736 to fix the failure when SMB was not enabled.

There has to be something else. I disabled SMB1 by running Disable-WindowsOptionalFeature -Online -FeatureName SMB1Protocol but I still can't reproduce the TestNetworkSymbolicLink failure.

On my computer, execute Disable WindowsOptionalFeature Online FeatureName SMB1Protocol to turn off SMB and the test will fail. Execute Enable WindowsOptionalFeature Online FeatureName SMB1Protocol to turn on SMB and the test will succeed.

On my computer, execute Disable WindowsOptionalFeature Online FeatureName SMB1Protocol to turn off SMB and the test will fail. Execute Enable WindowsOptionalFeature Online FeatureName SMB1Protocol to turn on SMB and the test will succeed.

I'm not putting that in doubt. What I meant is that there should be another Windows capability or configuration that is missing in your computer that makes the test fail when SMB1Protocol is disabled, as I can pass the test with SMB1Protocol disabled. Therefore, if we skip the test when SMB1Protocol is disabled, we will be missing coverage from valid environments, like mine.

https://learn.microsoft.com/en-us/windows-server/storage/file-server/troubleshoot/smbv1-not-installed-by-default-in-windows says that SMBv1 is not installed by default on some Windows versions, including the version I tested on — and I did not install it explicitly.

But: @qiulaidongfeng, I do think you may be on to something with https://go.dev/cl/512736. If the SMB Server service is running but the client is disabled — or if the server is only serving SMBv2/SMBv3 but the client is only configured to use SMBv1 — then the call to NetShareAdd could succeed (because the server is able to set up the share) but the call to Stat would then fail (because the client is unavailable to connect to it).

@qmuntal Thank you for telling me that disabling SMB can still pass the test. I have found that even if SMB is disabled, enabling the Workstation service on Windows will pass the test.

@bcmills I have updated CL 512736 to avoid testing failures when the Workstation service is not enabled.

@qmuntal Thank you for telling me that disabling SMB can still pass the test. I have found that even if SMB is disabled, enabling the Workstation service on Windows will pass the test.

Yay! I disabled the Workstation and got the The network path was not found error.

Can the WaitingForInfo label be removed?

Label removed. @qiulaidongfeng mark all resolved CL 512736 comments as resolved, either using the Done button or checking the Resolved checkbox. This is normally done by the CL owner, not the reviewer. There are less chances to get reviews if there are unresolved comments.

Label removed. @qiulaidongfeng mark all resolved CL 512736 comments as resolved, either using the Done button or checking the Resolved checkbox. This is normally done by the CL owner, not the reviewer. There are less chances to get reviews if there are unresolved comments.

Thank you.