Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: track TestGetDevelVersion failures #61462

Closed
dmitshur opened this issue Jul 20, 2023 · 1 comment
Closed

x/build/internal/task: track TestGetDevelVersion failures #61462

dmitshur opened this issue Jul 20, 2023 · 1 comment
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/build/internal/task" && test == "TestGetDevelVersion"

This test talks to the real Gerrit instance over the internet on longtest builders only. It will fail whenever Gerrit is experiencing unavailability or whenever the longtest builders' internet access runs into problems.

That means the test is inherently flaky. I expect the flake rate should be low enough not to be a problem, and filing this bug to automatically track how often such flakes happen via watchflakes.
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 20, 2023
@dmitshur dmitshur added this to the Unreleased milestone Jul 20, 2023
@dmitshur dmitshur self-assigned this Jul 20, 2023
@dmitshur
Copy link
Contributor Author

dmitshur commented Sep 7, 2023

So far the data points suggest the flake rate is at an acceptable (to me) rate. At least it's not unreasonably high.

Closing since doesn't need active work and watchflakes will still post results.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Release
Archived in project
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
1 participant
@dmitshur