Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestParseFileModifyAST failures #61429

Closed
gopherbot opened this issue Jul 18, 2023 · 2 comments
Closed

x/tools/go/packages: TestParseFileModifyAST failures #61429

gopherbot opened this issue Jul 18, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/go/packages" && test == "TestParseFileModifyAST"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestParseFileModifyAST (33.41s)
    --- FAIL: TestParseFileModifyAST/Modules (1.32s)
        packages_test.go:917: err: exit status 2: stderr: fatal error: all goroutines are asleep - deadlock!

panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 4024 [running]:
testing.tRunner.func1.2({0x82e67a0, 0x6deda3e0})
	/tmp/workdir/go/src/testing/testing.go:1545 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1548 +0x438
panic({0x82e67a0, 0x6deda3e0})
	/tmp/workdir/go/src/runtime/panic.go:914 +0x1e0
golang.org/x/tools/go/packages_test.testParseFileModifyAST(0x6aed42d0, {0x83696b8, 0x84e56e0})
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:921 +0x2f1
golang.org/x/tools/go/packages_test.testAllOrModulesParallel.func1(0x6aed42d0, {0x83696b8, 0x84e56e0})
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:81 +0x185
golang.org/x/tools/go/packages/packagestest.TestAll.func1(0x6aed42d0)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/packagestest/export.go:162 +0x51
testing.tRunner(0x6aed42d0, 0x6a6a9e30)
	/tmp/workdir/go/src/testing/testing.go:1595 +0x11a
created by testing.(*T).Run in goroutine 77
	/tmp/workdir/go/src/testing/testing.go:1648 +0x3d7

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 18, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/packages" && test == "TestParseFileModifyAST"
2023-07-18 19:54 openbsd-386-72 tools@03275ec1 go@813aad51 x/tools/go/packages.TestParseFileModifyAST (log) 
--- FAIL: TestParseFileModifyAST (33.41s)
    --- FAIL: TestParseFileModifyAST/Modules (1.32s)
        packages_test.go:917: err: exit status 2: stderr: fatal error: all goroutines are asleep - deadlock!

panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 4024 [running]:
testing.tRunner.func1.2({0x82e67a0, 0x6deda3e0})
	/tmp/workdir/go/src/testing/testing.go:1545 +0x2a5
testing.tRunner.func1()
	/tmp/workdir/go/src/testing/testing.go:1548 +0x438
panic({0x82e67a0, 0x6deda3e0})
	/tmp/workdir/go/src/runtime/panic.go:914 +0x1e0
golang.org/x/tools/go/packages_test.testParseFileModifyAST(0x6aed42d0, {0x83696b8, 0x84e56e0})
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:921 +0x2f1
golang.org/x/tools/go/packages_test.testAllOrModulesParallel.func1(0x6aed42d0, {0x83696b8, 0x84e56e0})
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:81 +0x185
golang.org/x/tools/go/packages/packagestest.TestAll.func1(0x6aed42d0)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/packages/packagestest/export.go:162 +0x51
testing.tRunner(0x6aed42d0, 0x6a6a9e30)
	/tmp/workdir/go/src/testing/testing.go:1595 +0x11a
created by testing.(*T).Run in goroutine 77
	/tmp/workdir/go/src/testing/testing.go:1648 +0x3d7

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jul 18, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 19, 2023

Duplicate of #55161

@bcmills bcmills marked this as a duplicate of #55161 Jul 19, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot