Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: Possible breaking change with Pselect on linux #61402

Closed
mauri870 opened this issue Jul 17, 2023 · 1 comment
Closed

x/sys/unix: Possible breaking change with Pselect on linux #61402

mauri870 opened this issue Jul 17, 2023 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Unreleased

Comments

@mauri870
Copy link
Member

mauri870 commented Jul 17, 2023 •
edited

Follow up to https://go-review.googlesource.com/c/sys/+/510195
Relates to #61251

Jesse Rittner words:

The Go Pselect wrapper never followed this requirement, which means this is a breaking change. 
I agree it was technically a bug, but it can break existing programs in hard-to-detect ways, 
particularly where EINTR is involved.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 17, 2023
@ianlancetaylor
Copy link
Contributor

Thanks, but I think that changing this is fine. We are not as strict about backward compatibility in the x/sys repo as we are in the standard library.

@ianlancetaylor ianlancetaylor closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
@ianlancetaylor ianlancetaylor mentioned this issue Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @mauri870