Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for go.dkinom.dev/baseconv/characters #61400

Closed
dkin-om opened this issue Jul 17, 2023 · 13 comments
Closed

x/pkgsite: package removal request for go.dkinom.dev/baseconv/characters #61400

dkin-om opened this issue Jul 17, 2023 · 13 comments
Labels
pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@dkin-om
Copy link

dkin-om commented Jul 17, 2023

What is the path of the package that you would like to have removed?

go.dkinom.dev/baseconv/characters

Are you the owner of this package?

Yes

What is the reason that you could not retract this package instead?

Removed the module from GitHub repo

@gopherbot gopherbot added this to the Unreleased milestone Jul 17, 2023
@seankhliao seankhliao added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Jul 18, 2023
@seankhliao
Copy link
Member

please try following the instructions at #60985 (comment)

@seankhliao seankhliao added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 18, 2023
@dkin-om
Copy link
Author

dkin-om commented Jul 18, 2023

@seankhliao I did as advised in the comment. It's been over an hour. Module is not retracted from pkgsite yet.

@bcmills
Copy link
Contributor

bcmills commented Jul 18, 2023

According to https://proxy.golang.org/cached-only/go.dkinom.dev/baseconv/characters/@latest, the most recent version of go.dkinom.dev/baseconv/characters fetched through proxy.golang.org is godsfood/baseconv@357f22fe, which is two commits behind the one containing the retract directives.

(Did you forget step 3 of the instructions in that comment? Perhaps you accidentally fetched the root module instead of the nested one?)

@dkin-om
Copy link
Author

dkin-om commented Jul 18, 2023

Yes, I did step 3. It failed with the following error, even when v0.2.3 git tag exists.

❯ go mod download go.dkinom.dev/baseconv/characters@v0.2.3
go: go.dkinom.dev/baseconv/characters@v0.2.3: invalid version: unknown revision characters/v0.2.3

By the way, module go.dkinom.dev/baseconv already exists, not sure if it has anything to do with the above error.

@bcmills
Copy link
Contributor

bcmills commented Jul 18, 2023

That error message is correct: the v0.2.3 tag applies to only the root module, not the nested one.
go mod download go.dkinom.dev/basecon/characters@master does the right thing, though:

~$ go mod download -json go.dkinom.dev/baseconv/characters@master
{
        "Path": "go.dkinom.dev/baseconv/characters",
        "Version": "v0.0.0-20230718102946-3bd85f839063",
        "Query": "master",
        "Info": "/usr/local/google/home/bcmills/pkg/mod/cache/download/go.dkinom.dev/baseconv/characters/@v/v0.0.0-20230718102946-3bd85f839063.info",
        "GoMod": "/usr/local/google/home/bcmills/pkg/mod/cache/download/go.dkinom.dev/baseconv/characters/@v/v0.0.0-20230718102946-3bd85f839063.mod",
        "Zip": "/usr/local/google/home/bcmills/pkg/mod/cache/download/go.dkinom.dev/baseconv/characters/@v/v0.0.0-20230718102946-3bd85f839063.zip",
        "Dir": "/usr/local/google/home/bcmills/pkg/mod/go.dkinom.dev/baseconv/characters@v0.0.0-20230718102946-3bd85f839063",
        "Sum": "h1:1bcDVdiIr4VDthkjR7WiBOAHej2Ujg/5dVn32663KEY=",
        "GoModSum": "h1:gRR8MVtSp14lHHB/Zeo6V3QCrY6iwzAphxPrY0dDVyo=",
        "Origin": {
                "VCS": "git",
                "URL": "https://github.com/godsfood/baseconv",
                "Subdir": "characters",
                "Hash": "3bd85f839063b2b23ccab1be6cd4c87940d2cda1"
        }
}

@bcmills
Copy link
Contributor

bcmills commented Jul 18, 2023

(So maybe give it another hour for that version to propagate to pkg.go.dev, since I just fetched it. 😅)

@bcmills
Copy link
Contributor

bcmills commented Jul 18, 2023

It should have updated by now. I'm escalating to the proxy.golang.org maintainers to figure out what's going on.

@bcmills
Copy link
Contributor

bcmills commented Jul 18, 2023

This turns out to be a bug in go list, filed as #61415.

@bcmills
Copy link
Contributor

bcmills commented Jul 18, 2023

In the meantime you may be able to work around it by adding a tag for the nested module on the latest commit, like characters/v0.0.0-retracted.

@dkin-om
Copy link
Author

dkin-om commented Jul 18, 2023

This turns out to be a bug in go list, filed as #61415.

Thank you.

In the meantime you may be able to work around it by adding a tag for the nested module on the latest commit, like characters/v0.0.0-retracted.

Let me try this.

@seankhliao seankhliao added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Jul 19, 2023
@dkin-om
Copy link
Author

dkin-om commented Jul 22, 2023

In the meantime you may be able to work around it by adding a tag for the nested module on the latest commit, like characters/v0.0.0-retracted.

Let me try this.

This worked. Now, https://pkg.go.dev/go.dkinom.dev/baseconv/characters is retracted.

But, In the go.dkinom.dev/baseconv module's directories section on the pkgsite I still see reference to go.dkinom.dev/baseconv/characters module. Is this an expected behaviour? Can't the references/links to characters module be removed?

@bcmills
Copy link
Contributor

bcmills commented Jul 24, 2023

I agree that the “Directories” entry seems inappropriate; I've filed #61554 for that.

@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 24, 2023
@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 24, 2023
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants