Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: testing/slogtest: move to log/slog/slogtest #61389

Closed
willfaught opened this issue Jul 16, 2023 · 1 comment
Closed

proposal: testing/slogtest: move to log/slog/slogtest #61389

willfaught opened this issue Jul 16, 2023 · 1 comment
Labels
Milestone

Comments

@willfaught
Copy link
Contributor

willfaught commented Jul 16, 2023

I never saw this package mentioned in the slog proposal or elsewhere. Hopefully this isn't too late.

Test helpers should be with/near their packages, not put underneath the testing package. This makes these helpers more discoverable and easier to understand.

Assuming the idea of a new package for just this one function is still open to debate, instead of the above, I propose this package be merged into log/slog. A single function doesn't merit its own package, in my opinion. Test helpers belong with the code they're helping out with.

@gopherbot gopherbot added this to the Proposal milestone Jul 16, 2023
@willfaught
Copy link
Contributor Author

Just found iotest and fstest. This seems unlike to be accepted, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants