Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: build issues on AIX and Plan 9 #61341

Open
matloob opened this issue Jul 13, 2023 · 4 comments
Open

x/pkgsite: build issues on AIX and Plan 9 #61341

matloob opened this issue Jul 13, 2023 · 4 comments
Labels
OS-AIX OS-Plan9 pkgsite
Milestone
pkgsite/backlog

Comments

@matloob
Copy link
Contributor

matloob commented Jul 13, 2023

We've disabled the AIX and Plan 9 builders for pkgsite because of two dependencies that break on those platforms respectively:

Once these fixed either upstream or through removing a dependency, we can remove the code in x/build/dashboard/builders.go that disables these on the Plan9 and AIX builders and their misc-compile builders.
@gopherbot gopherbot added this to the Unreleased milestone Jul 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/509475 mentions this issue: dashboard: stop building packagesite on aix and plan9 misc-compile

gopherbot pushed a commit to golang/build that referenced this issue Jul 13, 2023
@matloob
dashboard: stop building packagesite on aix and plan9 misc-compile
9650047 
Also stop building pkgsite on wasip1 builders (both regular and
misc-compile if it comes to exist).

Also rename crossCompileBuildSet to miscCompileBuildSet to make its
purpose more clear.

For golang/go#61209
For golang/go#61341

Change-Id: If4ae44c8e60585d137b56e88b647ccd18b0855ff
Reviewed-on: https://go-review.googlesource.com/c/build/+/509475
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
@jamalc jamalc modified the milestones: Unreleased, pkgsite/later Jul 20, 2023
@jamalc
Copy link

jamalc commented Jul 20, 2023

@matloob anything left for this issue?

@matloob
Copy link
Contributor Author

matloob commented Jul 21, 2023

I was thinking that this issue could track the work to eventually reenable the plan9 and aix builders.

@gopherbot
Copy link

Change https://go.dev/cl/524935 mentions this issue: dashboard: reenable pkgsite on AIX builders

gopherbot pushed a commit to golang/build that referenced this issue Sep 1, 2023
@matloob
dashboard: reenable pkgsite on AIX builders
b268245 
We disabled pkgsite on the AIX builders because two of its
dependencies, on github.com/go-git/go-git/v5 and
github.com/go-git/go-billy/v5 are broken on AIX. But those
dependencies were removed in CL 510415, so pkgsite should be good to
run on AIX.

For golang/go#61341

Change-Id: Icb03ca532cdb08b6dd12ba5fa2c64b63cbfdfdb0
Reviewed-on: https://go-review.googlesource.com/c/build/+/524935
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Michael Matloob <matloob@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-AIX OS-Plan9 pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @matloob @jamalc