Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: crash in View.Options #61325

Closed
TristanSpeakEasy opened this issue Jul 12, 2023 · 8 comments
Closed

x/tools/gopls: crash in View.Options #61325

TristanSpeakEasy opened this issue Jul 12, 2023 · 8 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.0

Comments

@TristanSpeakEasy
Copy link

gopls version: v0.12.4 (go1.20.5)
gopls flags:
update flags: proxy
extension version: 0.39.0
go version: 1.20.5
environment: Visual Studio Code linux
initialization error: undefined
issue timestamp: Wed, 12 Jul 2023 01:49:36 GMT
restart history:
Mon, 10 Jul 2023 06:01:44 GMT: activation (enabled: true)
Wed, 12 Jul 2023 00:24:00 GMT: manual (enabled: true)
Wed, 12 Jul 2023 00:38:53 GMT: manual (enabled: true)
Wed, 12 Jul 2023 00:49:51 GMT: manual (enabled: true)
Wed, 12 Jul 2023 01:15:40 GMT: manual (enabled: true)
Wed, 12 Jul 2023 01:42:51 GMT: manual (enabled: true)

ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.

Describe what you observed.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0xc3be7c]

goroutine 30894 [running]:
golang.org/x/tools/gopls/internal/lsp/cache.(*View).Options(0x115b080%3F)
	  view.go:405  0x3c
golang.org/x/tools/gopls/internal/lsp/cache.(*Session).DidModifyFiles(0xc0001229c0, {0x115b080, 0xc0037fd8f0}, {0xc00df32000, 0xcb, 0x0%3F})
	  session.go:455  0x1085
golang.org/x/tools/gopls/internal/lsp.(*Server).didModifyFiles(0xc00039a4e0, {0x115b080%3F, 0xc0037fd8f0}, {0xc00e7ceb90, 0x1, 0x1}, 0x2)
	  text_synchronization.go:273  0x513
golang.org/x/tools/gopls/internal/lsp.(*Server).didChangeWatchedFiles(0xd5d700%3F, {0x115b080%3F, 0xc00442d860%3F}, 0xc00680fc08)
	  text_synchronization.go:189  0x315
golang.org/x/tools/gopls/internal/lsp.(*Server).DidChangeWatchedFiles(0xc00ddd6000%3F, {0x115b080%3F, 0xc00442d860%3F}, 0xd5d700%3F)
	  server_gen.go:60  0x25
golang.org/x/tools/gopls/internal/lsp/protocol.serverDispatch({0x115b080, 0xc00442d860}, {0x116bcd0, 0xc00039a4e0}, 0xc0037fd830, {0x115b2e8, 0xc00442d7a0})
	  tsserver.go:646  0x5444
golang.org/x/tools/gopls/internal/lsp/protocol.ServerHandler.func1({0x115b080, 0xc00442d860}, 0xc0037fd830, {0x115b2e8, 0xc00442d7a0})
	  protocol.go:157  0x90
golang.org/x/tools/gopls/internal/lsp/lsprpc.handshaker.func1({0x115b080, 0xc00442d860}, 0xc0037fd830, {0x115b2e8%3F, 0xc00442d7a0%3F})
	  lsprpc.go:519  0x9f9
golang.org/x/tools/internal/jsonrpc2.MustReplyHandler.func1({0x115b080, 0xc00442d860}, 0xc00d5081c8, {0x115b2e8%3F, 0xc00442d7a0%3F})
	  handler.go:35  0xf6
golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1.2()
	  handler.go:103  0xa3
created by golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1
	  handler.go:100  0x20a
[Error - 11:49:23 AM]

OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.

NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
DO NOT SHARE LOGS IF YOU ARE WORKING IN A PRIVATE REPOSITORY.

<OPTIONAL: ATTACH LOGS HERE>
@hyangah
Copy link
Contributor

hyangah commented Jul 12, 2023

Thanks for the report! @TristanSpeakEasy
We will transfer this to the gopls issue tracker.

@hyangah hyangah transferred this issue from golang/vscode-go Jul 12, 2023
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jul 12, 2023
@hyangah hyangah added this to the gopls/v0.12.5 milestone Jul 12, 2023
@findleyr findleyr self-assigned this Jul 13, 2023
@findleyr findleyr changed the title gopls: automated issue report (crash) x/tools/gopls: crash in View.Options Jul 13, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jul 13, 2023
@findleyr
Copy link
Contributor

Hi @TristanSpeakEasy I see also from your activation history that you had manually restarted the language server several times. Could you share why you had to do that?

@findleyr
Copy link
Contributor

This is really strange. The crash indicates that a view in Session.views is nil. Granted, there is some tricky logic updating that field when views are removed or updated, but I've gone through that logic twice now (and once with @adonovan) and it appears sound to me.

@TristanSpeakEasy this is not reproducible, right?

@findleyr
Copy link
Contributor

Moving this to gopls@v0.13.0, as I don't think we'll be able to figure this out in time for the v0.12.5 release, this crash must by very unlikely, and there's no way to avoid the crash even if we don't understand it: if Session.views contains a nil element, the game is over.

@findleyr findleyr modified the milestones: gopls/v0.12.5, gopls/v0.13.0 Jul 13, 2023
@TristanSpeakEasy
Copy link
Author

So I have only seen the crash once so far, but I do get a lot of other weird behaviour with our work flow.

Basically we develop a SDK Generation product and so we are quite often going through a flow of deleting and regenerating an entire Go project over and over again.

I generally have to restart the Go language server after each generation as it stops providing any intellisense after a generation.

@findleyr
Copy link
Contributor

I generally have to restart the Go language server after each generation as it stops providing any intellisense after a generation.

Thanks for the explanation. Is this product open-source? I'd be interested in debugging.

@TristanSpeakEasy
Copy link
Author

TristanSpeakEasy commented Jul 13, 2023 •
edited

It’s not open source but it is available to use freely at the moment. It is a SDK generator from an OpenAPI document.

We have a CLI tool that can be downloaded and used to generate a Go project over and over again https://speakeasyapi.dev/docs/speakeasy-cli/getting-started/ which causes the exact same behaviour if the go project is open in VSCode when you are regenerating

@gopherbot
Copy link

Change https://go.dev/cl/526159 mentions this issue: gopls/internal/lsp: move options into the snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @findleyr @TristanSpeakEasy