Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: ppc64le: sign extension issue in go 1.21rc2 [1.20 backport] #61320

Closed
gopherbot opened this issue Jul 12, 2023 · 2 comments
Closed

cmd/compile: ppc64le: sign extension issue in go 1.21rc2 [1.20 backport] #61320

gopherbot opened this issue Jul 12, 2023 · 2 comments
Labels
arch-ppc64x CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.20.7

Comments

@gopherbot
Copy link

@pmur requested issue #61297 to be considered for backport to the next 1.20 minor release.

@gopherbot please consider a backport for 1.20 and 1.19, this is a compiler bug without a workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 12, 2023
@gopherbot gopherbot mentioned this issue Jul 12, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 12, 2023
@gopherbot gopherbot added this to the Go1.20.7 milestone Jul 12, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/509195 mentions this issue: [release-branch.go1.20] cmd/compile: on PPC64, fix sign/zero extension when masking

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Jul 19, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 19, 2023
@gopherbot
Copy link
Author

Closed by merging 6211a02 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Jul 19, 2023
@pmur @gopherbot
[release-branch.go1.20] cmd/compile: on PPC64, fix sign/zero extensio…
6211a02 
…n when masking

(ANDCCconst [y] (MOV.*reg x)) should only be merged when zero
extending. Otherwise, sign bits are lost on negative values.

(ANDCCconst [0xFF] (MOVBreg x)) should be simplified to a zero
extension of x. Likewise for the MOVHreg variant.

Fixes #61320

Change-Id: I04e4fd7dc6a826e870681f37506620d48393698b
Reviewed-on: https://go-review.googlesource.com/c/go/+/508775
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/509195
Auto-Submit: Heschi Kreinick <heschi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-ppc64x CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.20.7
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi