Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Version lists seem to not always be up to date #61312

Closed
rhalar opened this issue Jul 12, 2023 · 2 comments
Closed

x/pkgsite: Version lists seem to not always be up to date #61312

rhalar opened this issue Jul 12, 2023 · 2 comments
Labels
pkgsite
Milestone
Unreleased

Comments

@rhalar
Copy link

rhalar commented Jul 12, 2023 •
edited

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/goharbor/harbor
https://pkg.go.dev/github.com/goharbor/harbor/src/core/api

What is your user agent?

Chromium or Firefox of some sort

What did you do?

Visited the URLs above

What did you expect to see?

See all releases present on https://github.com/goharbor/harbor in the version list on the pkg.go.dev page.

What did you see instead?

The harbor module link stopped updating after version 1.8.6, which is listed as the latest release, even though it is a few years old now. The second URL does not list any versions at all, I am not sure if this is expected though.

Running
go list -m -versions github.com/goharbor/harbor

returns all of the expected versions, though with the incompatible suffix.
@rhalar rhalar added the pkgsite label Jul 12, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 12, 2023
@gophun
Copy link

gophun commented Jul 12, 2023

I don't see a go.mod in github.com/goharbor/harbor

I see one under src/, but that constitutes a different module: https://pkg.go.dev/github.com/goharbor/harbor/src
This one doesn't have any version tags, because they would have to be prefixed with the subdirectory name: src/vX.Y.Z. Also, a version >= 2.0.0 would require a /v2 suffix to the module path in the go.mod file.

It seems to me that the maintainer of harbor doesn't understand the interplay of go.mod files, versions, tags and module paths.

@seankhliao
Copy link
Member

see above, I believe pkgsite is working as intended.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
@rhalar rhalar mentioned this issue Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@gopherbot @seankhliao @gophun @rhalar