Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/workspace: TestQuickFix_AddGoWork fails with released go 1.21+ #61307

Closed
hyangah opened this issue Jul 11, 2023 · 1 comment
Closed

x/tools/gopls/internal/regtest/workspace: TestQuickFix_AddGoWork fails with released go 1.21+ #61307

hyangah opened this issue Jul 11, 2023 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.13.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Jul 11, 2023

Go version go1.21rc2

The behavior of the go command is changing, and the test needs fixing to work with go1.21+.

#### End Gopls Test Logs for "TestQuickFix_AddGoWork/use_all/experimental"
--- FAIL: TestQuickFix_AddGoWork (22.95s)
    --- FAIL: TestQuickFix_AddGoWork/use_b (8.02s)
        --- FAIL: TestQuickFix_AddGoWork/use_b/default (3.05s)
            quickfix_test.go:208: unexpected go.work content:
                --- want
                +++ got
                @@ -1,4 +1,4 @@
                -go 1.21
                +go 1.21rc2
                 
                 use ./b
...
FAIL
FAIL    golang.org/x/tools/gopls/internal/regtest/workspace     233.461s
@hyangah hyangah added the gopls Issues related to the Go language server, gopls. label Jul 11, 2023
@hyangah hyangah added this to the gopls/v0.12.5 milestone Jul 11, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jul 11, 2023
@gopherbot
Copy link

Change https://go.dev/cl/508801 mentions this issue: gopls/internal/regtest/workspace: fix TestQuickFix_AddGoWork for go1.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.13.0
Development

No branches or pull requests
2 participants
@hyangah @gopherbot