Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis: report informative error message about gob.Register(fact) conflicts #61304

Open
adonovan opened this issue Jul 11, 2023 · 0 comments
Open

x/tools/go/analysis: report informative error message about gob.Register(fact) conflicts #61304

adonovan opened this issue Jul 11, 2023 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

gob.Register has an unfortunately unfixable bug whereby two packages registering types *p/a.T and *q/a.T get a panic because internally their names are both mapped to *a.T. Witness: https://go.dev/play/p/HtGLdqhHvaG

The analysis.Validate function has the opportunity to detect and report this confusing problem with a helpful explanation. Basically one of the types must be renamed.

@hyangah
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jul 11, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 11, 2023
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @cherrymui