Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: data race in testServerExpect #61301

Closed
gopherbot opened this issue Jul 11, 2023 · 4 comments
Closed

net/http: data race in testServerExpect #61301

gopherbot opened this issue Jul 11, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented Jul 11, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && log ~ `WARNING: DATA RACE` && log ~ `net/http_test.testServerExpect`

Issue created automatically to collect these failures.

Example (log):

==================
WARNING: DATA RACE
Read at 0x00c0004d81e3 by goroutine 12452:
  testing.(*common).logDepth()
      /workdir/go/src/testing/testing.go:998 +0x4c4
  testing.(*common).log()
      /workdir/go/src/testing/testing.go:985 +0xa4
  testing.(*common).Logf()
      /workdir/go/src/testing/testing.go:1036 +0x6a
  net/http_test.testServerExpect.func2.1()
...
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1906 +0xb44
  net/http_test.TestMain()
      /workdir/go/src/net/http/main_test.go:23 +0x2e
  main.main()
      _testmain.go:1119 +0x324
==================
--- FAIL: TestOnlyWriteTimeout (0.00s)
    --- FAIL: TestOnlyWriteTimeout/h1 (0.02s)
        testing.go:1446: race detected during execution of test

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestOnlyWriteTimeout"
2023-07-06 19:41 linux-amd64-race go@312920c0 net/http.TestOnlyWriteTimeout (log) 
==================
WARNING: DATA RACE
Read at 0x00c0004d81e3 by goroutine 12452:
  testing.(*common).logDepth()
      /workdir/go/src/testing/testing.go:998 +0x4c4
  testing.(*common).log()
      /workdir/go/src/testing/testing.go:985 +0xa4
  testing.(*common).Logf()
      /workdir/go/src/testing/testing.go:1036 +0x6a
  net/http_test.testServerExpect.func2.1()
...
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1906 +0xb44
  net/http_test.TestMain()
      /workdir/go/src/net/http/main_test.go:23 +0x2e
  main.main()
      _testmain.go:1119 +0x324
==================
--- FAIL: TestOnlyWriteTimeout (0.00s)
    --- FAIL: TestOnlyWriteTimeout/h1 (0.02s)
        testing.go:1446: race detected during execution of test

— watchflakes

@bcmills bcmills changed the title net/http: TestOnlyWriteTimeout failures net/http: data race in testServerExpect Jul 11, 2023
@bcmills bcmills added this to the Backlog milestone Jul 11, 2023
This was referenced Jul 11, 2023
Closed
Closed
@bcmills
Copy link
Contributor

bcmills commented Jul 11, 2023

(attn @neild)

@bcmills
Copy link
Contributor

bcmills commented Jul 11, 2023

Note that commit 312920c is on release-branch.go1.20. It is not obvious to me whether this race also exists on the main branch.

@bcmills
Copy link
Contributor

bcmills commented Jul 11, 2023

Duplicate of #59883

@bcmills bcmills marked this as a duplicate of #59883 Jul 11, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot