Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/poller: TestStats failures with MillisToLastByte out of expected range #61273

Open
gopherbot opened this issue Jul 10, 2023 · 9 comments
Open

x/pkgsite/internal/poller: TestStats failures with MillisToLastByte out of expected range #61273

gopherbot opened this issue Jul 10, 2023 · 9 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
pkgsite/backlog

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jul 10, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestStats (0.69s)
    stats_test.go:72: MillisToLastByte is 689, wanted 500 +/- 50

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats"
2023-06-30 19:55 linux-s390x-ibm pkgsite@32beeac0 go@449ef379 x/pkgsite/internal/poller.TestStats (log) 
--- FAIL: TestStats (0.69s)
    stats_test.go:72: MillisToLastByte is 689, wanted 500 +/- 50

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2023
@bcmills bcmills changed the title x/pkgsite/internal/poller: TestStats failures x/pkgsite/internal/poller: TestStats failures with MillisToLastByte out of expected range Jul 11, 2023
@bcmills bcmills mentioned this issue Jul 11, 2023
Open
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-07-18 18:00 linux-s390x-ibm pkgsite@f466d5d0 go@5fe3f0a2 x/pkgsite/internal/poller.TestStats (log) 
2023/07/19 09:04:47 Info: caching response of length 25 for /A
2023/07/19 09:04:47 Debug: serving "/A" from cache
2023/07/19 09:04:47 Info: caching response of length 25 for /A
2023/07/19 09:04:47 Debug: serving "/A" from cache
2023/07/19 09:04:49 Error: middleware.Panic: panic!
--- FAIL: TestStats (0.90s)
    stats_test.go:72: MillisToLastByte is 904, wanted 500 +/- 50
2023-07-19 19:15 linux-s390x-ibm pkgsite@64dbd74b go@5fe3f0a2 x/pkgsite/internal/poller.TestStats (log) 
2023/07/19 15:24:00 Info: caching response of length 25 for /A
2023/07/19 15:24:00 Debug: serving "/A" from cache
2023/07/19 15:24:00 Info: caching response of length 25 for /A
2023/07/19 15:24:00 Debug: serving "/A" from cache
2023/07/19 15:24:01 Error: middleware.Panic: panic!
--- FAIL: TestStats (0.55s)
    stats_test.go:72: MillisToLastByte is 554, wanted 500 +/- 50

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-07-24 20:30 linux-s390x-ibm pkgsite@0bc4b0e9 go@89a45784 x/pkgsite/internal/poller.TestStats (log) 
2023/07/24 16:35:44 Info: caching response of length 25 for /A
2023/07/24 16:35:44 Debug: serving "/A" from cache
2023/07/24 16:35:44 Info: caching response of length 25 for /A
2023/07/24 16:35:44 Debug: serving "/A" from cache
2023/07/24 16:35:47 Error: middleware.Panic: panic!
--- FAIL: TestStats (1.05s)
    stats_test.go:72: MillisToLastByte is 1048, wanted 500 +/- 50

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-07-24 20:30 linux-s390x-ibm pkgsite@0bc4b0e9 go@598958f0 x/pkgsite/internal/poller.TestStats (log) 
2023/07/26 19:58:50 Info: caching response of length 25 for /A
2023/07/26 19:58:50 Debug: serving "/A" from cache
2023/07/26 19:58:50 Info: caching response of length 25 for /A
2023/07/26 19:58:50 Debug: serving "/A" from cache
2023/07/26 19:58:51 Error: middleware.Panic: panic!
--- FAIL: TestStats (1.16s)
    stats_test.go:72: MillisToLastByte is 1158, wanted 500 +/- 50

— watchflakes

@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Jul 27, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-08-03 16:46 linux-s390x-ibm pkgsite@7ec3a4ee go@74caf475 x/pkgsite/internal/poller.TestStats (log) 
2023/08/04 00:06:34 Info: caching response of length 25 for /A
2023/08/04 00:06:34 Debug: serving "/A" from cache
2023/08/04 00:06:34 Info: caching response of length 25 for /A
2023/08/04 00:06:34 Debug: serving "/A" from cache
2023/08/04 00:06:36 Error: middleware.Panic: panic!
--- FAIL: TestStats (0.88s)
    stats_test.go:72: MillisToLastByte is 876, wanted 500 +/- 50

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-08-04 21:05 linux-s390x-ibm pkgsite@52eb2284 go@a4b6685c x/pkgsite/internal/poller.TestStats (log) 
--- FAIL: TestStats (0.72s)
    stats_test.go:72: MillisToLastByte is 719, wanted 500 +/- 50

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-08-04 21:05 linux-s390x-ibm pkgsite@1e939987 go@0ae54ddd x/pkgsite/internal/poller.TestStats (log) 
--- FAIL: TestStats (0.57s)
    stats_test.go:72: MillisToLastByte is 565, wanted 500 +/- 50

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-08-04 21:05 linux-s390x-ibm pkgsite@52eb2284 go@adb775e3 x/pkgsite/internal/poller.TestStats (log) 
--- FAIL: TestStats (0.58s)
    stats_test.go:72: MillisToLastByte is 577, wanted 500 +/- 50

— watchflakes

@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 8, 2023

(CC @matloob)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: No status
Milestone
pkgsite/backlog
Development

No branches or pull requests
3 participants
@hyangah @bcmills @gopherbot