Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/xcontext: TestDetach failures missing DeadlineExceeded error #61272

Closed
gopherbot opened this issue Jul 10, 2023 · 5 comments
Closed

x/pkgsite/internal/xcontext: TestDetach failures missing DeadlineExceeded error #61272

gopherbot opened this issue Jul 10, 2023 · 5 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
pkgsite/backlog

Comments

@gopherbot
Copy link

gopherbot commented Jul 10, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestDetach" && `original context Err: got .nil., want DeadlineExceeded`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestDetach (0.80s)
    xcontext_test.go:30: original context Err: got <nil>, want DeadlineExceeded

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestDetach"
2023-07-06 20:26 linux-s390x-ibm pkgsite@17701c53 go@39c50707 x/pkgsite/internal/xcontext.TestDetach (log) 
--- FAIL: TestDetach (0.80s)
    xcontext_test.go:30: original context Err: got <nil>, want DeadlineExceeded

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestDetach"
2023-06-28 17:58 linux-s390x-ibm pkgsite@a9d9eedc go@03cd8a7b x/pkgsite/internal/xcontext.TestDetach (log) 
--- FAIL: TestDetach (0.57s)
    xcontext_test.go:30: original context Err: got <nil>, want DeadlineExceeded

— watchflakes

@bcmills bcmills changed the title x/pkgsite/internal/xcontext: TestDetach failures x/pkgsite/internal/xcontext: TestDetach failures missing DeadlineExceeded error Jul 11, 2023
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Jul 27, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestDetach" && `original context Err: got .nil., want DeadlineExceeded`
2023-07-31 22:57 linux-s390x-ibm pkgsite@0d6a9589 go@2300f7ef x/pkgsite/internal/xcontext.TestDetach (log) 
--- FAIL: TestDetach (0.89s)
    xcontext_test.go:30: original context Err: got <nil>, want DeadlineExceeded

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Aug 8, 2023

This is just an invalid timing assumption in the test. It is assuming that after a 500ms sleep, the 200ms timeout has been applied.

@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Aug 8, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 22, 2023

Fixed by https://go.dev/cl/517296.

@bcmills bcmills closed this as completed Aug 22, 2023
@bcmills bcmills self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
pkgsite/backlog
Development

No branches or pull requests
3 participants
@hyangah @bcmills @gopherbot