Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/poller: TestCache failures with CacheResultCount diff #61270

Open
gopherbot opened this issue Jul 10, 2023 · 1 comment
Open

x/pkgsite/internal/poller: TestCache failures with CacheResultCount diff #61270

gopherbot opened this issue Jul 10, 2023 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/backlog

Comments

@gopherbot
Copy link

gopherbot commented Jul 10, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestCache" && `CacheResultCount diff`

Issue created automatically to collect these failures.

Example (log):

2023/07/06 21:59:58 Info: caching response of length 25 for /A
2023/07/06 21:59:58 Debug: serving "/A" from cache
2023/07/06 21:59:58 Info: caching response of length 25 for /A
2023/07/06 21:59:58 Info: cache get("/A"): context timed out
2023/07/06 21:59:58 Info: caching response of length 25 for /A
--- FAIL: TestCache (0.29s)
    caching_test.go:159: [A is cached again] GET returned body 5, want 4
    caching_test.go:177: [A is cached again] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
    caching_test.go:177: [bypassing the cache] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
2023/07/06 21:59:59 Error: middleware.Panic: panic!

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestCache"
2023-06-30 19:55 linux-s390x-ibm pkgsite@32beeac0 go@449ef379 x/pkgsite/internal/poller.TestCache (log) 
2023/07/06 21:59:58 Info: caching response of length 25 for /A
2023/07/06 21:59:58 Debug: serving "/A" from cache
2023/07/06 21:59:58 Info: caching response of length 25 for /A
2023/07/06 21:59:58 Info: cache get("/A"): context timed out
2023/07/06 21:59:58 Info: caching response of length 25 for /A
--- FAIL: TestCache (0.29s)
    caching_test.go:159: [A is cached again] GET returned body 5, want 4
    caching_test.go:177: [A is cached again] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
    caching_test.go:177: [bypassing the cache] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
2023/07/06 21:59:59 Error: middleware.Panic: panic!

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2023
@bcmills bcmills changed the title x/pkgsite/internal/poller: TestCache failures x/pkgsite/internal/poller: TestCache failures with CacheResultCount diff Jul 11, 2023
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
Test Flakes
Status: No status
Milestone
pkgsite/backlog
Development

No branches or pull requests
3 participants
@hyangah @bcmills @gopherbot