Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: TestReset failures #61266

Closed
gopherbot opened this issue Jul 10, 2023 · 3 comments
Closed

time: TestReset failures #61266

gopherbot opened this issue Jul 10, 2023 · 3 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "time" && test == "TestReset"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestReset (2.58s)
    sleep_test.go:436: resetting unfired timer returned false

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "time" && test == "TestReset"
2023-06-08 17:09 linux-s390x-ibm go@bff4b0ed time.TestReset (log) 
--- FAIL: TestReset (2.58s)
    sleep_test.go:436: resetting unfired timer returned false
2023-06-09 00:01 linux-s390x-ibm go@ce8eadf5 time.TestReset (log) 
--- FAIL: TestReset (2.37s)
    sleep_test.go:436: resetting unfired timer returned false

— watchflakes

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jul 10, 2023
@bcmills bcmills added this to the Backlog milestone Jul 10, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 10, 2023

This test has a hard-coded upper bound on the timeout that tops out at about ⅓ s.
https://cs.opensource.google/go/go/+/master:src/time/sleep_test.go;l=418-427;drc=af7f417665fb1612eb9865c7ab4992bf095148e2

The fix is presumably to increase that timeout to a number that is more reasonable on a heavily-loaded machine.

@gopherbot
Copy link
Author

Change https://go.dev/cl/508695 mentions this issue: time: increase arbitrary upper bound in TestReset to 10s

@bcmills bcmills self-assigned this Jul 11, 2023
@bcmills bcmills modified the milestones: Backlog, Go1.21 Jul 11, 2023
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@bradfitz
time: increase arbitrary upper bound in TestReset to 10s
20476b3 
The previous upper bound was around 0.375 s, which is empirically
too short on a slow, heavily-loaded builder. Since the test doesn't
seem to depend on the actual duration in any meaningful way, let's
make it several orders of magnitude larger.

Fixes golang#61266.

Change-Id: I6dde5e174966ee385db67e3cb87334f463c7e597
Reviewed-on: https://go-review.googlesource.com/c/go/+/508695
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot