Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get go@1.21 should work better #61259

Closed
rsc opened this issue Jul 10, 2023 · 2 comments
Closed

cmd/go: go get go@1.21 should work better #61259

rsc opened this issue Jul 10, 2023 · 2 comments
Labels
GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@rsc
Copy link
Contributor

rsc commented Jul 10, 2023

In a go 1.12 module using Go built at tip:

% go get go@1.21
go: go@1.21: no matching versions for query "1.21"

It seems like since the local Go toolchain knows Go 1.21, this should be permitted.
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 10, 2023
@rsc rsc added this to the Go1.21 milestone Jul 10, 2023
@bcmills bcmills added the GoCommand cmd/go label Jul 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/509097 mentions this issue: cmd/go: fix go get go@badversion

@gopherbot
Copy link

Change https://go.dev/cl/509217 mentions this issue: cmd/go/internal/modfetch: always allow Stat for the current toolchain to succeed

gopherbot pushed a commit that referenced this issue Jul 13, 2023
@gopherbot
cmd/go/internal/modfetch: always allow Stat for the current toolchain…
b88bd91 
… to succeed

This fixes a failure mode observed in TestScript/gotoolchain_version
when building go1.21rc3.

Updates #61259.

Change-Id: Ifb14a5b94b687adea7a26c1155591e3ae75b7a62
Reviewed-on: https://go-review.googlesource.com/c/go/+/509217
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@rsc @bradfitz
cmd/go: fix go get go@badversion
bdc95d9 
It was panicking instead of printing a nice error.

Fixes golang#61258.
Fixes golang#61259.

Change-Id: Ia30853db5bc7f1f2a4c7e91169c659ae2b79adcb
Reviewed-on: https://go-review.googlesource.com/c/go/+/509097
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@bradfitz
cmd/go/internal/modfetch: always allow Stat for the current toolchain…
d59d9e4 
… to succeed

This fixes a failure mode observed in TestScript/gotoolchain_version
when building go1.21rc3.

Updates golang#61259.

Change-Id: Ifb14a5b94b687adea7a26c1155591e3ae75b7a62
Reviewed-on: https://go-review.googlesource.com/c/go/+/509217
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@rsc @bcmills @gopherbot