Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log/slog: don't write nil contexts [freeze exception] #61226

Closed
jba opened this issue Jul 7, 2023 · 1 comment
Closed

log/slog: don't write nil contexts [freeze exception] #61226

jba opened this issue Jul 7, 2023 · 1 comment
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@jba
Copy link
Contributor

jba commented Jul 7, 2023

As #61219 points out, we should not pass nil where a context.Context is expected.
https://go.dev/cl/508437 contains the fix, which includes code as well as documentation.

/cc @golang/release
@seankhliao seankhliao added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 7, 2023
@seankhliao seankhliao added this to the Go1.21 milestone Jul 7, 2023
@heschi
Copy link
Contributor

heschi commented Jul 7, 2023

No need for a freeze exemption for documentation and test updates. The production change is tiny and seems obviously safe, but maybe I'd have left it out just to keep the risk to zero. Anyway, approved.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Jul 10, 2023
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 10, 2023
@jba jba closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
5 participants
@bcmills @gopherbot @seankhliao @jba @heschi