Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: rethink serverDispatcher.ExecuteCommand #61217

Open
adonovan opened this issue Jul 6, 2023 · 0 comments
Open

x/tools/gopls: rethink serverDispatcher.ExecuteCommand #61217

adonovan opened this issue Jul 6, 2023 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@adonovan
Copy link
Member

adonovan commented Jul 6, 2023

In CL https://go-review.git.corp.google.com/c/tools/+/505875 I would have added this comment in the implementation of serverDispatcher.ExecuteCommand, but I can't because it's generated code.

// TODO(adonovan): allow the caller to pass in the result
// pointer so they can avoid an unnecessary JSON-to-any
// decoding and re-encoding to JSON before finally decoding to
// the correct Go struct type. (Also: the specific result
// type depends on the implementation of ExecuteCommand:
// (*Server).ExecuteCommand returns the specific Go type!
// This is not a meaningful interface.)

This issue is a reminder to clean it up.
@adonovan adonovan self-assigned this Jul 6, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 6, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/later Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr