-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: Tricium should not enforce Go style rules on testdata/*.go #61214
Comments
Also include automatically generated files. |
I think @rsc suggested that we disable the Tricium check entirely. Its spell-checker has a number of idiosyncrasies specific to Chromium that don't really apply to Go. |
Change https://go.dev/cl/508865 mentions this issue: |
This change temporarily disables the tricium copyright check. It will be enabled again when it can be customized to work with the Go project. Updates golang/go#61214 Change-Id: Ia69bc19f34b9f253c393ebf3b5b81e10b7aef0b8 Reviewed-on: https://go-review.googlesource.com/c/build/+/508865 Reviewed-by: Heschi Kreinick <heschi@google.com> Auto-Submit: Carlos Amedee <carlos@golang.org> TryBot-Bypass: Carlos Amedee <carlos@golang.org>
The copyright check has been temporarily disabled. |
The implementation of the check we were using previously is fully gone as of CL 643916. I'll close this since the original problem is no longer happening and so the issue is not actionable, but we'll need to take testdata files into account when/if considering a future equivalent check. |
The new Tricium CI system keeps pointing out that *.go files don't have a copyright header, even when they are in a testdata directory. Test data files sometimes need to be subtly invalid Go for a wide variety of reasons, and the CI system shouldn't try to make them look like production code.
The text was updated successfully, but these errors were encountered: