Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: get the builders green #61209

Open
matloob opened this issue Jul 6, 2023 · 10 comments
Open

x/pkgsite: get the builders green #61209

matloob opened this issue Jul 6, 2023 · 10 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/backlog

Comments

@matloob
Copy link
Contributor

matloob commented Jul 6, 2023

This issue is for getting the builders for x/pkgsite passing.
@gopherbot gopherbot added this to the Unreleased milestone Jul 6, 2023
@findleyr
Copy link
Contributor

findleyr commented Jul 6, 2023

Kokoro currently sets the TryBot-Result label. I think we need to solve that ownership model first.

@hyangah
Copy link
Contributor

hyangah commented Jul 7, 2023

Is it a duplicate of #59347 or a subtask of it?

@matloob
Copy link
Contributor Author

matloob commented Jul 7, 2023

I think this is a subtask.

@hyangah hyangah mentioned this issue Jul 7, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/508655 mentions this issue: dashboard: disable pkgsite on misc-compile-aix-ppc64 builder

gopherbot pushed a commit to golang/build that referenced this issue Jul 10, 2023
@matloob @gopherbot
dashboard: disable pkgsite on misc-compile-aix-ppc64 builder
67e9336 
It doesn't build for the same reason the vulndb repo doesn't build: a
dependency on github.com/go-git/go-billy.

For golang/go#49218
For golang/go#61209

Change-Id: I220a56ee330ec6de6d6467c6ca71e7f536121462
Reviewed-on: https://go-review.googlesource.com/c/build/+/508655
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Michael Matloob <matloob@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/508864 mentions this issue: dashboard: disable pkgsite on plan9 builders

gopherbot pushed a commit to golang/build that referenced this issue Jul 12, 2023
@matloob
dashboard: disable pkgsite on plan9 builders
343d9c6 
Pkgsite depends on github.com/lib/pq for its database driver. pq is
broken on plan9. I've sent a pull request to fix them but it seems
like it will be a while until it's looked at. Disable the builders for
now.

For golang/go#61209

Change-Id: I1fba995662cc0b1756ac00b9de11d264412f2f79
Reviewed-on: https://go-review.googlesource.com/c/build/+/508864
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/509475 mentions this issue: dashboard: stop building packagesite on aix and plan9 misc-compile

gopherbot pushed a commit to golang/build that referenced this issue Jul 13, 2023
@matloob
dashboard: stop building packagesite on aix and plan9 misc-compile
9650047 
Also stop building pkgsite on wasip1 builders (both regular and
misc-compile if it comes to exist).

Also rename crossCompileBuildSet to miscCompileBuildSet to make its
purpose more clear.

For golang/go#61209
For golang/go#61341

Change-Id: If4ae44c8e60585d137b56e88b647ccd18b0855ff
Reviewed-on: https://go-review.googlesource.com/c/build/+/509475
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
@jamalc jamalc modified the milestones: Unreleased, pkgsite/later Jul 20, 2023
@gopherbot
Copy link

Change https://go.dev/cl/524797 mentions this issue: all: skip tests that can't run on wasm platforms

@gopherbot
Copy link

Change https://go.dev/cl/524799 mentions this issue: internal/stdlib: mark TestResolveSupportedBranches as requiring git

@gopherbot
Copy link

Change https://go.dev/cl/524798 mentions this issue: internal/licences: use relative path to open testdata

gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 31, 2023
@matloob
all: skip tests that can't run on wasm platforms
67eeede 
Some because the network support isn't enough for httpreplay, and some
because we need the Go command.

For golang/go#61209

Change-Id: I02c6b7d10553d931c746723ce9608f39834c131c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/524797
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Michael Matloob <matloob@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 31, 2023
@matloob
internal/licences: use relative path to open testdata
92416b2 
We don't need to do the extra work to construct the that's being done
in testDataPath because the test will be run in the directory of the
test file. In addition, this is broken on the android builders because
they build on a different machine than where the tests run.

For golang/go#61209

Change-Id: I066cde3d972e21d52240d9c518524569d60a65f7
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/524798
kokoro-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 31, 2023
@matloob
internal/stdlib: mark TestResolveSupportedBranches as requiring git
12a45f8 
ResolveSupportedBranches uses the git command, and the Windows
longtest builders don't have git, so skip the test when git isn't
present.

For golang/go#61209

Change-Id: I230793c76702ad0c3e153f9d70031a370b20ac30
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/524799
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/524947 mentions this issue: dashboard: disable pkgsite for pre-1.21 android builders

gopherbot pushed a commit to golang/build that referenced this issue Sep 1, 2023
@matloob
dashboard: disable pkgsite for pre-1.21 android builders
c0b6c31 
The pkgsite tests need CL 472096, released in 1.21 to run properly.
Don't run them on 1.20 and earlier.

For golang/go#59347
For golang/go#61209

Change-Id: I32ba9652401db3b1fb9f23c9777e4514332abaef
Reviewed-on: https://go-review.googlesource.com/c/build/+/524947
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
6 participants
@hyangah @bcmills @gopherbot @matloob @jamalc @findleyr