Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: extended forwards compatibility for Go [1.19 backport] #61197

Closed
gopherbot opened this issue Jul 6, 2023 · 2 comments
Closed

cmd/go: extended forwards compatibility for Go [1.19 backport] #61197

gopherbot opened this issue Jul 6, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.19.13

Comments

@gopherbot
Copy link

@dmitshur requested issue #57001 to be considered for backport to the next 1.19 minor release.

@gopherbot Please consider a specific subset of this proposal for backport to Go 1.20 and 1.19. Specifically, https://go.dev/doc/toolchain currently documents that:

[...] Go 1.​21 changed the go line to be a mandatory requirement instead. This behavior is partly backported to earlier language versions: Go 1.19 releases starting at Go 1.19.11 and Go 1.20 releases starting at Go 1.20.6, refuse to load workspaces or modules declaring version Go 1.​21 or later.

This backport issue tracks backporting that refusal of loading workspaces or modules declaring version Go 1.​21 or later. (If it ends up happening in later minor versions, the wording on https://go.dev/doc/toolchain can be updated retroactively.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 6, 2023
@gopherbot gopherbot mentioned this issue Jul 6, 2023
Closed
@dmitshur dmitshur added the GoCommand cmd/go label Jul 6, 2023
@gopherbot gopherbot added this to the Go1.19.11 milestone Jul 6, 2023
@dmitshur dmitshur changed the title extended forwards compatibility for Go [1.19 backport] cmd/go: extended forwards compatibility for Go [1.19 backport] Jul 6, 2023
@gopherbot gopherbot modified the milestones: Go1.19.11, Go1.19.12 Jul 11, 2023
@gopherbot gopherbot modified the milestones: Go1.19.12, Go1.19.13 Aug 1, 2023
@rsc
Copy link
Contributor

rsc commented Aug 15, 2023

Fixed by CL 518815.

@rsc rsc closed this as completed Aug 15, 2023
@rsc
Copy link
Contributor

rsc commented Aug 15, 2023

Note that the issue description above is incorrect: The important thing is to refuse to load Go 1.22 or later, since that's where we expect the incompatibility to arise. Allowing these releases to run Go 1.21 code is fine.

@bcmills bcmills added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 15, 2023
@dmitshur dmitshur mentioned this issue Aug 16, 2023
Closed
@kzantow kzantow mentioned this issue Aug 29, 2023
Closed
@atc0005 atc0005 mentioned this issue Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.19.13
Development

No branches or pull requests
4 participants
@rsc @dmitshur @bcmills @gopherbot