-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: panic in OriginMethod #61196
Comments
I would be grateful for a tip on how to make this work on any version (except for switching to vim). |
To my surprise, only my "favourite" project makes gopls panic. I've created hello-world app, go.mod, go.work and everything seems fine in that window. gopls server output (the one that's panicking):
|
Thank you for the stack trace. Transferring to the gopls issue tracker. I'm not quite sure how this panic could be reached: it indicates a bug in either the type checker or importer. Is your project open-source? We can put in a workaround for the crash, but it would be unsatisfying if we didn't understand how it is reached. |
Change https://go.dev/cl/508795 mentions this issue: |
Improve the panic message to help debug golang/go#61196. Updates golang/go#61196 Change-Id: Ia3ab9583886d67b971914310e82a99a1a2b15a59 Reviewed-on: https://go-review.googlesource.com/c/tools/+/508795 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> gopls-CI: kokoro <noreply+kokoro@google.com>
The CL above should make this panic more useful. Could you please build gopls @ master, and provide us the improved panic?
Thank you! |
This may be a consequence of #61561. |
Closing this as I am pretty sure it is a consequence of #61561, and should have been largely mitigated by gopls@v0.13.0 (and fixed using go@master). |
gopls version: v0.12.4 (go1.20.5)
gopls flags:
update flags: proxy
extension version: 0.39.0
go version: 1.20.5
environment: Visual Studio Code darwin
initialization error: undefined
issue timestamp: Thu, 29 Jun 2023 19:06:21 GMT
restart history:
Thu, 29 Jun 2023 19:06:09 GMT: activation (enabled: true)
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Describe what you observed.
gopls server started crashing after update. It crashes right after launching VSCode or installing Go extension.I've tried:
OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.
NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
DO NOT SHARE LOGS IF YOU ARE WORKING IN A PRIVATE REPOSITORY.
<OPTIONAL: ATTACH LOGS HERE>
The text was updated successfully, but these errors were encountered: