Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/s390x: Adding Crypto mnemonics to the assembler #61163

Closed
srinivas-pokala opened this issue Jul 4, 2023 · 4 comments
Closed

cmd/internal/obj/s390x: Adding Crypto mnemonics to the assembler #61163

srinivas-pokala opened this issue Jul 4, 2023 · 4 comments
Assignees
@srinivas-pokala
Labels
arch-s390x Issues solely affecting the s390x architecture. compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@srinivas-pokala
Copy link
Contributor

Currently a few crypto intsructions in the s390x Architecture's are hardcoded using BYTE and WORD. Need to add KDSA, KM,KMC,KMCTR,KIMD,KMA, KLMD instructions to go assembler.

@golang/s390x
@srinivas-pokala srinivas-pokala added the arch-s390x Issues solely affecting the s390x architecture. label Jul 4, 2023
@bcmills bcmills added this to the Backlog milestone Jul 5, 2023
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Jul 5, 2023
@gopherbot
Copy link

Change https://go.dev/cl/509075 mentions this issue: cmd/asm: add s390x crypto related instructions

@srinivas-pokala
Copy link
Contributor Author

Added CL for adding KM,KMC,KIMD,KLMD instructions to the assembler.

@gopherbot
Copy link

Change https://go.dev/cl/515195 mentions this issue: Add assembly mnemonics for KMA and KMCTR instruction

@Vishwanatha-HD
Copy link
Contributor

Raised a CL to add the assembly instruction mnemonics for KMA and KMCTR instructions. CL link is:
https://go-review.googlesource.com/c/go/+/515195

gopherbot pushed a commit that referenced this issue Sep 5, 2023
@Vishwanatha-HD @cherrymui
cmd/asm: add KMA and KMCTR instructions on s390x.
a40404d 
This CL is to add assembly instruction mnemonics for the following instructions, mainly used in crypto packages.

 * KMA    - cipher message with authentication
 * KMCTR  - cipher message with counter

Fixes #61163

Change-Id: Iff9a69911aeb4fab4bca8755b23a106eaebb2332
Reviewed-on: https://go-review.googlesource.com/c/go/+/515195
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srinivas-pokala srinivas-pokala

Labels
arch-s390x Issues solely affecting the s390x architecture. compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@mknyszek @bcmills @gopherbot @srinivas-pokala @Vishwanatha-HD