Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort: avoid calling rand.Seed in test helpers #61142

Closed
suyashtava opened this issue Jul 2, 2023 · 5 comments
Closed

sort: avoid calling rand.Seed in test helpers #61142

suyashtava opened this issue Jul 2, 2023 · 5 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.23

Comments

@suyashtava
Copy link

sort_benchmark_go
is using rand.Seed() which is depreciated, and we should be using latest procedure(Doc) for benchmarking.
@gopherbot gopherbot added this to the Proposal milestone Jul 2, 2023
@suyashtava suyashtava mentioned this issue Jul 2, 2023
Closed
@suyashtava
Copy link
Author

Solving PR: #61143

@mvdan
Copy link
Member

mvdan commented Jul 2, 2023

This does not need to be a proposal.

@mvdan mvdan changed the title proposal: sort benchmark test is still using deprecated function. sort: benchmark test is still using deprecated function. Jul 2, 2023
@mvdan mvdan removed this from the Proposal milestone Jul 2, 2023
@mvdan mvdan removed the Proposal label Jul 2, 2023
@suyashtava
Copy link
Author

suyashtava commented Jul 2, 2023 •
edited

This does not need to be a proposal.

Contributing to go lang for the first time, might have misunderstood some guideline.

Can you pls also check the attached pr.

@bcmills bcmills added Documentation Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. and removed Documentation labels Jul 5, 2023
@bcmills bcmills added this to the Backlog milestone Jul 5, 2023
@bcmills bcmills changed the title sort: benchmark test is still using deprecated function. sort: avoid calling rand.Seed in makeRandomInts test helper Jul 5, 2023
@bcmills bcmills changed the title sort: avoid calling rand.Seed in makeRandomInts test helper sort: avoid calling rand.Seed in test helpers Jul 5, 2023
@gopherbot
Copy link

Change https://go.dev/cl/507575 mentions this issue: slices: in benchmarks remove call to rand.Seed

@dmitshur dmitshur modified the milestones: Backlog, Go1.21 Jul 7, 2023
@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@gopherbot
Copy link

Change https://go.dev/cl/551155 mentions this issue: sort: don't use deprecated rand.Seed in benchmarks

@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@tklauser @ezz-no
sort: use math/rand/v2 in tests and benchmarks
aa22f8c 
This allows to drop the use of deprecated rand.Seed in benchmarks.

Fixes golang#61142

Change-Id: I628848c0d4a500dc9a361930c393e47c3361a95c
Reviewed-on: https://go-review.googlesource.com/c/go/+/551155
Reviewed-by: Eli Bendersky <eliben@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.23
Development

Successfully merging a pull request may close this issue.

slices: in benchmarks remove call to rand.Seed suyashtava/go
5 participants
@dmitshur @mvdan @bcmills @gopherbot @suyashtava