Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: frequent TestBreakpoint timeouts on plan9-amd64-0intro #61087

Closed
bcmills opened this issue Jun 30, 2023 · 4 comments
Closed

runtime: frequent TestBreakpoint timeouts on plan9-amd64-0intro #61087

bcmills opened this issue Jun 30, 2023 · 4 comments
Assignees
@psilva261
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 30, 2023 

#!watchflakes
post <- goos == "plan9" && pkg == "runtime" && test == "TestBreakpoint"

https://build.golang.org/log/ea934fa51d0c0cfd54392cf5a60d72483dda50e2:

panic: test timed out after 6m0s
running tests:
	TestBreakpoint (5m50s)
…
goroutine 23057 [syscall, 5 minutes]:
syscall.Syscall6(0x32, 0x4, 0x488d0c8d, 0x373, 0xffffffffffffffff, 0xffffffffffffffff, 0x0)
	/tmp/workdir-gnot/go/src/syscall/asm_plan9_amd64.s:63 +0x10 fp=0x49236cf0 sp=0x49236c38 pc=0x2821d0
syscall.Pread(0x488c4c40?, {0x488d0c8d?, 0x49236eec?, 0x2?}, 0x12?)
	/tmp/workdir-gnot/go/src/syscall/zsyscall_plan9_amd64.go:218 +0x5e fp=0x49236d68 sp=0x49236cf0 pc=0x281c7e
syscall.Read(...)
	/tmp/workdir-gnot/go/src/syscall/syscall_plan9.go:170
os.(*File).read(0x48728440, {0x488d0c8d, 0x373, 0x373})
	/tmp/workdir-gnot/go/src/os/file_plan9.go:286 +0xeb fp=0x49236dd8 sp=0x49236d68 pc=0x29f68b
os.(*File).Read(0x49f2fd70?, {0x488d0c8d, 0x373, 0x373})
	/tmp/workdir-gnot/go/src/os/file.go:118 +0x65 fp=0x49236e20 sp=0x49236dd8 pc=0x29d485
bytes.(*Buffer).ReadFrom(0x49f2fd70, {0x6c1c80, 0x48728440})
	/tmp/workdir-gnot/go/src/bytes/buffer.go:211 +0x98 fp=0x49236e78 sp=0x49236e20 pc=0x2d9b98
io.copyBuffer({0x6c1d00, 0x49f2fd70}, {0x6c1c80, 0x48728440}, {0x0, 0x0, 0x0})
	/tmp/workdir-gnot/go/src/io/io.go:416 +0x147 fp=0x49236ef8 sp=0x49236e78 pc=0x297707
io.Copy(...)
	/tmp/workdir-gnot/go/src/io/io.go:389
os/exec.(*Cmd).writerDescriptor.func1()
	/tmp/workdir-gnot/go/src/os/exec/exec.go:560 +0x34 fp=0x49236f58 sp=0x49236ef8 pc=0x330a94
os/exec.(*Cmd).Start.func2(0x48871f20?)
	/tmp/workdir-gnot/go/src/os/exec/exec.go:717 +0x2c fp=0x49236fc8 sp=0x49236f58 pc=0x33180c
os/exec.(*Cmd).Start.func3()
	/tmp/workdir-gnot/go/src/os/exec/exec.go:729 +0x27 fp=0x49236fe0 sp=0x49236fc8 pc=0x3317a7
runtime.goexit()
	/tmp/workdir-gnot/go/src/runtime/asm_amd64.s:1650 +0x1 fp=0x49236fe8 sp=0x49236fe0 pc=0x273a61
created by os/exec.(*Cmd).Start in goroutine 23055
	/tmp/workdir-gnot/go/src/os/exec/exec.go:716 +0xa65

(attn @golang/plan9)
@bcmills bcmills added OS-Plan9 compiler/runtime Issues related to the Go compiler and/or runtime. labels Jun 30, 2023
@bcmills bcmills added this to the Backlog milestone Jun 30, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Jun 30, 2023

The symptoms here look very similar to #60793: an exec.Cmd is blocked on reading a pipe from a child process that has crashed or otherwise terminated.

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 30, 2023
@0intro
Copy link
Member

0intro commented Jun 30, 2023

CC @millerresearch

@psilva261
Copy link
Member

Actually when running src/runtime/testdata/testprog Breakpoint directly the output is:

sys: breakpoint pc=0x25e200
PC=0x25e200

goroutine 1 [running]:
testprog 19395: suicide: sys: floating point in note handler pc=0x202860
testprog 19395: sys: floating point in note handler pc=0x202860

It's similar to #24387 where internal/bytealg.IndexByteString is called which uses floating point instructions in the note handler. I'll create a CL for that.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/508400 mentions this issue: runtime: don't use floating point in traceback on Plan 9

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Jul 20, 2023
@golang golang locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@psilva261 psilva261

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Projects
Test Flakes
Archived in project
Milestone
Backlog
Development

No branches or pull requests
5 participants
@cagedmantis @psilva261 @bcmills @0intro @gopherbot