Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: problems with module zips may not be caught until release time #61078

Open
heschi opened this issue Jun 29, 2023 · 0 comments
Open
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented Jun 29, 2023

In #60847 we saw that the module zips were broken, and we didn't find out until after the release had been half-published. Ideally we would have in-band tests of some kind that catch this.

I understand that generating them is expensive, and it may not be so easy to test without adding a lot of latency to the builders. But catching problems at release time is pretty costly too. So I think it makes sense to spend a little time thinking about it.

cc @rsc @bcmills @matloob

@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2023
@heschi heschi added this to the Go1.22 milestone Jun 29, 2023
@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants