Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/watchflakes: fails to attribute *** Test killed with quit: failures to the running test #61070

Open
bcmills opened this issue Jun 29, 2023 · 2 comments
Open

x/build/cmd/watchflakes: fails to attribute *** Test killed with quit: failures to the running test #61070

bcmills opened this issue Jun 29, 2023 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 29, 2023

In #57995 (comment), I see a test failure ending in:

*** Test killed with quit: ran too long (4m0s).
FAIL	bytes	240.041s

but watchflakes matched that to the explicit condition test == "" .

This pattern should be fairly easy to match, so watchflakes should attribute these failures to the correct package's tests.

(attn @cherrymui)
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 29, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 29, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Jun 29, 2023

Hrm, and then when I excluded Test killed with quit from #57995, watchflakes filed #61071 with the correct package path.

So maybe the bug here is that test == "" incorrectly matches failures that have a non-empty test?

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 30, 2023
@cagedmantis
Copy link
Contributor

/cc @golang/release for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @bcmills @gopherbot