Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: TestMarkers/implementation/generics.txt failure #61005

Closed
findleyr opened this issue Jun 26, 2023 · 2 comments
Closed

x/tools/gopls: TestMarkers/implementation/generics.txt failure #61005

findleyr opened this issue Jun 26, 2023 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.13.0

Comments

@findleyr
Copy link
Contributor

There is one failure from #60584 that seems to be of a different nature:

https://build.golang.org/log/6b41887dc7ce6783c1f3b91a04932ddb4ba6ada8

--- FAIL: TestMarkers (124.23s)
    --- FAIL: TestMarkers/implementation/generics.txt (1.10s)
        marker.go:488: other/other.go:7:54 (implementation/generics.txt:30:54): implementation: incorrect result locations: (got 0, want 1):
              []string{
            - 	"implementation/implementation.go:11:6-19 (implementation/generics.txt:21:6-19)",
              }
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

I suspect that this could be a race to instance expansion causing it to miss methods (which would also explain some rare type error reported by users).
@findleyr findleyr added this to the gopls/v0.12.5 milestone Jun 26, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 26, 2023
@findleyr
Copy link
Contributor Author

I feel pretty confident this is #61561.

@gopherbot
Copy link

Change https://go.dev/cl/512636 mentions this issue: gopls/internal/lsp/cache: memoize active packages after every operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.13.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr