Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: omit "Output" section for examples with no output #60986

Open
rsc opened this issue Jun 24, 2023 · 1 comment · May be fixed by golang/pkgsite#68
Open

x/pkgsite: omit "Output" section for examples with no output #60986

rsc opened this issue Jun 24, 2023 · 1 comment · May be fixed by golang/pkgsite#68
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/backlog

Comments

@rsc
Copy link
Contributor

rsc commented Jun 24, 2023

Here is an example with no output:
https://pkg.go.dev/github.com/vmg/backoff#example-Ticker

The code is here:
https://go-mod-viewer.appspot.com/github.com/vmg/backoff@v1.0.0/example_test.go#L21

There are no // Output comments.

The display on pkg.go.dev should not show an "Output:" section.
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 24, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 24, 2023
AlexanderYastrebov added a commit to AlexanderYastrebov/pkgsite that referenced this issue Jun 28, 2023
@AlexanderYastrebov
internal/godoc/dochtml: omit "Output" section for examples with no ou…
e08209d 
…tput

Fixes golang/go#60986
@AlexanderYastrebov AlexanderYastrebov linked a pull request Jun 28, 2023 that will close this issue
Open
@suzmue suzmue modified the milestones: Unreleased, pkgsite/later Jun 29, 2023
@AlexanderYastrebov
Copy link
Contributor

PR is ready

AlexanderYastrebov added a commit to AlexanderYastrebov/pkgsite that referenced this issue Sep 23, 2023
@AlexanderYastrebov
internal/godoc/dochtml: omit "Output" section for examples with no ou…
cd64704 
…tput

Fixes golang/go#60986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

Successfully merging a pull request may close this issue.

internal/godoc/dochtml: omit "Output" section for examples with no output AlexanderYastrebov/pkgsite
4 participants
@rsc @AlexanderYastrebov @suzmue @gopherbot