x/tools/gopls: improve the gopls bug
subcommand, and use it more widely
#60969
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Following https://go.dev/issue/60963, we had a discussion around when it is correct to use
log.Fatal
,panic
, orbug.Reportf
, when encountering an "impossible" condition in gopls.Summarizing conclusions:
bug.Reportf
orbug.Errorf
and keep going. (thebug
package was written to allow making gopls incrementally more assertive, without crashing).log.Fatal
panic
(this will allow VS Code crash reporting to capture the stack, among other things).Action items:
gopls bug
subcommand with any bug reports captured in the file cacheThe text was updated successfully, but these errors were encountered: