Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.12.4 #60955

Closed
8 tasks done
findleyr opened this issue Jun 22, 2023 · 2 comments
Closed
8 tasks done

x/tools/gopls: release version v0.12.4 #60955

findleyr opened this issue Jun 22, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.4

Comments

@findleyr
Copy link
Contributor

findleyr commented Jun 22, 2023 •
edited

This issue tracks progress toward releasing gopls@v0.12.4

  • cherry-pick into gopls-release-branch.0.12
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.12.4-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.12.4
@findleyr findleyr added this to the gopls/v0.12.4 milestone Jun 22, 2023
@findleyr findleyr self-assigned this Jun 22, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 22, 2023
@gopherbot
Copy link

Change https://go.dev/cl/505355 mentions this issue: gopls: update go.mod for v0.12.4

gopherbot pushed a commit to golang/tools that referenced this issue Jun 22, 2023
@findleyr
gopls: update go.mod for v0.12.4
0622ad2 
Remove the replace directive and update x/tools.

For golang/go#60955

Change-Id: If6d38e59d65e64f344fb7ddce5873450b2694a4a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/505355
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/505356 mentions this issue: gopls: update go.mod for v0.12.4

gopherbot pushed a commit to golang/tools that referenced this issue Jun 22, 2023
@findleyr
gopls: update go.mod for v0.12.4
72cd703 
Update x/tools.

For golang/go#60955

Change-Id: I114fde5deb34105bce75a4a69b90752516c5c1fc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/505356
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.4
Development

No branches or pull requests
2 participants
@gopherbot @findleyr