New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding/xml: more tests #6094
Labels
Milestone
Comments
Updated by https://golang.org/cl/47870043 |
CL https://golang.org/cl/92230043 mentions this issue. |
rsc
added
accepted
Suggested
Issues that may be good for new contributors looking for work to do.
Testing
An issue that has been verified to require only test changes, not just a test failure.
labels
May 11, 2014
I think this issue can now be closed, we are at 86.2% coverage at commit 0ed70ef $ pwd
/Users/emmanuelodeke/go/src/go.googlesource.com/go/src/encoding/xml
$ go version
go version devel +0ed70ef Wed Feb 3 04:33:08 2016 +0000 darwin/amd64
$ go test -cover
PASS
coverage: 86.2% of statements
ok encoding/xml 0.012s |
Shouldn't it be closed at 100%? |
Coverage is not a good metric. Even 100% line coverage is not a guarantee
of actual coverage. The initial report mentioned trying to test
interactions between the different features. Line coverage only guarantees
they are tested in isolation.
|
I agree that 100% coverage isn't a guarantee for much, but I would see it as a minimum. |
Gotcha, sounds like a plan. I'll try taking a stab at this for Go1.7. |
Change https://golang.org/cl/263317 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: