Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/unitchecker: TestVetStdlib failures [1.20 backport] #60927

Closed
gopherbot opened this issue Jun 21, 2023 · 2 comments
Closed

x/tools/go/analysis/unitchecker: TestVetStdlib failures [1.20 backport] #60927

gopherbot opened this issue Jun 21, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.20.6

Comments

@gopherbot
Copy link

@heschi requested issue #60058 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport to 1.20.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 21, 2023
@gopherbot gopherbot mentioned this issue Jun 21, 2023
Open
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 21, 2023
@gopherbot gopherbot modified the milestones: Unreleased, Go1.20.6 Jun 21, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/504977 mentions this issue: [release-branch.go1.20] all: make safe for new vet analyzer

@heschi heschi added Testing An issue that has been verified to require only test changes, not just a test failure. CherryPickApproved Used during the release process for point releases labels Jun 21, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 21, 2023
@gopherbot
Copy link
Author

Closed by merging c32f1af to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Jun 21, 2023
@heschi @gopherbot
[release-branch.go1.20] all: make safe for new vet analyzer
c32f1af 
The unused analyzer handles dot imports now, so a few tests
have picked up vet errors. This CL errors like:

context/x_test.go:524:47: result of context.WithValue call not used

This is a manual cherry-pick of CL 493598.

Updates #60058
Fixes #60927

Change-Id: I92906ef7967e14a85fa974e6307fd689e3ff3dba
Reviewed-on: https://go-review.googlesource.com/c/go/+/504977
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Bypass: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.20.6
Development

No branches or pull requests
2 participants
@gopherbot @heschi