Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/rsa: release notes for 1.21 mention GOOS instead of GOARCH #60924

Closed
artyom opened this issue Jun 21, 2023 · 3 comments
Closed

crypto/rsa: release notes for 1.21 mention GOOS instead of GOARCH #60924

artyom opened this issue Jun 21, 2023 · 3 comments
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@artyom
Copy link
Member

artyom commented Jun 21, 2023

Release notes at https://tip.golang.org/doc/go1.21 under “crypto/rsa” section say that:

The performance of private RSA operations (decryption and signing) is now better than Go 1.19 for GOOS=amd64 and GOOS=arm64.

I think it should be GOARCH instead of GOOS here.

diff --git doc/go1.21.html doc/go1.21.html
index 1d49084325..c25f94a2d9 100644
--- doc/go1.21.html
+++ doc/go1.21.html
@@ -495,7 +495,7 @@ Do not send CLs removing the interior tags from such phrases.
 <dl id="crypto/rsa"><dt><a href="/pkg/crypto/rsa/">crypto/rsa</a></dt>
   <dd>
     <p><!-- CL 471259, CL 492935 -->
-      The performance of private RSA operations (decryption and signing) is now better than Go 1.19 for <code>GOOS=amd64</code> and <code>GOOS=arm64</code>. It had regressed in Go 1.20.
+      The performance of private RSA operations (decryption and signing) is now better than Go 1.19 for <code>GOARCH=amd64</code> and <code>GOARCH=arm64</code>. It had regressed in Go 1.20.
     </p>
     <p>
       Due to the addition of private fields to <a href="/pkg/crypto/rsa/#PrecomputedValues"><code>PrecomputedValues</code></a>, <a href="/pkg/crypto/rsa/#PrivateKey.Precompute"><code>PrivateKey.Precompute</code></a> must be called for optimal performance even if deserializing (for example from JSON) a previously-precomputed private key.
@Jorropo
Copy link
Member

Jorropo commented Jun 21, 2023

It should mention 1.20 not 1.19 right ?

@ianlancetaylor
Copy link
Contributor

Thanks.

(The mention of 1.19 is correct. See the whole paragraph.)

@gopherbot
Copy link

Change https://go.dev/cl/504879 mentions this issue: doc/go1.21: correct GOOS to GOARCH

@dmitshur dmitshur added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Jun 24, 2023
@dmitshur dmitshur added this to the Go1.21 milestone Jun 24, 2023
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@ianlancetaylor @bradfitz
doc/go1.21: correct GOOS to GOARCH
2ff0582 
For golang#57752
Fixes golang#60924

Change-Id: Ie1e16c041885abb51dd6c2f0b7dfa03091cfb338
Reviewed-on: https://go-review.googlesource.com/c/go/+/504879
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Eli Bendersky <eliben@google.com>
TryBot-Bypass: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
5 participants
@artyom @dmitshur @ianlancetaylor @gopherbot @Jorropo