Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modfetch/codehost: tests failing on Plan 9 because "git" is a minimal shell script #60923

Closed
millerresearch opened this issue Jun 21, 2023 · 4 comments
Closed

cmd/go/internal/modfetch/codehost: tests failing on Plan 9 because "git" is a minimal shell script #60923

millerresearch opened this issue Jun 21, 2023 · 4 comments
Assignees
@millerresearch
Labels
OS-Plan9

Comments

@millerresearch
Copy link
Contributor

The plan9-386 builder has been failing since CL 491659, which introduced or re-enabled tests which depend on git. The git command on Plan 9 is not the real thing but a minimal shell script, originally written to provide just enough functionality for go get to work. (See issue #29640.)

The new tests in this package are skipped if there's no git executable, but they should also be skipped on Plan 9, where the git executable doesn't support the subcommands needed in the tests.

Alternatively, maybe the pseudo git should now be removed from the plan9-386 and plan9-amd64 builders, since it's not needed by the current version of go get. I removed the pseudo git on the plan9-arm builders some years ago, with apparently no ill effect. @0intro, what do you think?
@millerresearch millerresearch self-assigned this Jun 21, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 21, 2023

One way or another, it would certainly simplify a lot of tests if we could rely on the property that a git found via exec.LookPath supports all of the same commands as the mainline git tool.

@millerresearch
Copy link
Contributor Author

One way or another, it would certainly simplify a lot of tests if we could rely on the property that a git found via exec.LookPath supports all of the same commands as the mainline git tool.

I think that property is only likely to be satisfied vacuously on Plan 9, ie by deleting or renaming the pseudo git.

Apart from its use in go get (now obsolete), there appear to be some other places the pseudo git is helpful, for example in finding go version for a development version of go in a git repository.

@0intro
Copy link
Member

0intro commented Jun 21, 2023

I've just renamed the git tool on the plan9-386 and plan9-amd64 builder.

@millerresearch
Copy link
Contributor Author

I've just renamed the git tool on the plan9-386 and plan9-amd64 builder.

Thanks - "All tests passed" on plan9-386.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millerresearch millerresearch

Labels
OS-Plan9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcmills @0intro @millerresearch