Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: x/tools/gopls: release version v0.12.3 #60917

Closed
8 tasks done
findleyr opened this issue Jun 21, 2023 · 5 comments
Closed
8 tasks done

x/tools/gopls: x/tools/gopls: release version v0.12.3 #60917

findleyr opened this issue Jun 21, 2023 · 5 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.3

Comments

@findleyr
Copy link
Contributor

findleyr commented Jun 21, 2023 •
edited

This issue tracks progress toward releasing gopls@v0.12.3

  • merge master into gopls-release-branch.0.12
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.12.3-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.12.3
@findleyr findleyr self-assigned this Jun 21, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 21, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 21, 2023
@gopherbot
Copy link

Change https://go.dev/cl/504815 mentions this issue: all: merge master (85554d6) into gopls-release-branch.0.12

gopherbot pushed a commit to golang/tools that referenced this issue Jun 21, 2023
@findleyr
all: merge master (85554d6) into gopls-release-branch.0.12
ce96f56 
Also tidy and add back the replace directive.

For golang/go#60917

Conflicts:

- gopls/go.mod
- gopls/go.sum

Merge List:

+ 2023-06-20 85554d6 gopls/internal/lsp/cache: add debugging assertion for golang/go#60904
+ 2023-06-20 9960b69 gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID
+ 2023-06-20 6480332 gopls/internal/lsp/cache: use types.Unsafe in analysisPackage
+ 2023-06-20 155320d gopls/internal/lsp/work: don't crash when hovering over broken mod dir
+ 2023-06-20 b71392a gopls/internal/lsp/cache: reduce importing in analysis
+ 2023-06-20 d1a388b internal/gcimporter: avoid a crash when exporting a struct with no pkg
+ 2023-06-16 a4ed05f cmd/digraph: add "to dot" to emit Graphviz dot
+ 2023-06-15 7261b32 gopls/internal/regtest: fix goimports on windows when using vendoring
+ 2023-06-14 41e4e56 gopls/internal/lsp/source/completion: ensuring completion completeness
+ 2023-06-14 ac29460 go/ssa: fix bug in writeSignature on external functions
+ 2023-06-14 3b62e7e go/ssa: use core type within (*builder).receiver
+ 2023-06-14 f394d45 gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously
+ 2023-06-14 27dbf85 go.mod: update golang.org/x dependencies
+ 2023-06-13 c6c9830 go/types/objectpath: memoize scope lookup in objectpath.Encoder
+ 2023-06-13 0245e1d gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor
+ 2023-06-13 85be888 go/analysis/passes/defers: add analyser for defer mistake
+ 2023-06-13 c43232f cmd/digraph: improve examples using go list, mod
+ 2023-06-12 6e1595c internal/gcimporter: treat unknown constant values the same as invalid
+ 2023-06-12 c59d87f gopls/internal/lsp/cache: two minor simplifications
+ 2023-06-10 db6a81e go/packages/packagestest: set Config.Logf if the test is run verbosely
+ 2023-06-06 a01290f internal/typeparams: work around LookupFieldOrMethod inconsistency
+ 2023-06-05 6f567c8 gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos
+ 2023-06-05 726c727 gopls/internal/lsp: enable min/max builtin completion test

Change-Id: I85926c5d711102941750ad122844c10d13acc09a
@gopherbot
Copy link

Change https://go.dev/cl/504816 mentions this issue: gopls/internal/lsp/debug: update hard-coded version for v0.12.3

gopherbot pushed a commit to golang/tools that referenced this issue Jun 21, 2023
@findleyr
gopls/internal/lsp/debug: update hard-coded version for v0.12.3
429e4ee 
For golang/go#60917

Change-Id: I21868a206f35bb06d4b492a1bb97e021d174cb82
Reviewed-on: https://go-review.googlesource.com/c/tools/+/504816
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/504817 mentions this issue: gopls: update go.mod for v0.12.3

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.3 Jun 21, 2023
@gopherbot
Copy link

Change https://go.dev/cl/504895 mentions this issue: all: merge master (0ca9d30) into gopls-release-branch.0.12

gopherbot pushed a commit to golang/tools that referenced this issue Jun 21, 2023
@findleyr
all: merge master (0ca9d30) into gopls-release-branch.0.12
79dae4d 
For golang/go#60917

Merge List:

+ 2023-06-21 0ca9d30 gopls/internal/lsp/cache: fix nil panic in analysis toSourceDiagnostic

Change-Id: I7a0549558c829424e61917af61695a2a37c1a969
@gopherbot
Copy link

Change https://go.dev/cl/504896 mentions this issue: gopls: update go.mod for v0.12.3

gopherbot pushed a commit to golang/tools that referenced this issue Jun 21, 2023
@findleyr
gopls: update go.mod for v0.12.3
5056bc8 
Remove the replace directive and update x/tools.

For golang/go#60917

Change-Id: Ib74ea83cfbe68ee97f3da47353de75b237fcd5c0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/504896
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.3
Development

No branches or pull requests
2 participants
@gopherbot @findleyr