Skip to content

go/types, types2: type-checking invalid IndexExprs should use their operands #60906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Jun 20, 2023 · 1 comment
Closed

go/types, types2: type-checking invalid IndexExprs should use their operands #60906

findleyr opened this issue Jun 20, 2023 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.22

Comments

@findleyr
Copy link
Member 

func _() {
	var x int
	var f func() []int
	_ = f[x]
}

https://go.dev/play/p/ev4lDI7nxQ-

Outputs:

./prog.go:6:6: x declared and not used
./prog.go:8:7: invalid operation: cannot index f (variable of type func() []int)

But x is used. On go1.17 there is just one error: ./run.go:10:15: invalid operation: f[x] (type func() []int does not support indexing).

CC @griesemer
@findleyr findleyr added this to the Go1.22 milestone Jun 20, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/504877 mentions this issue: go/types, types2: avoid spurious "declared and not used" error

bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@griesemer @bradfitz
go/types, types2: avoid spurious "declared and not used" error

Verified

This commit was signed with the committer’s verified signature.
wooorm Titus
GPG key ID: E6E581152ED04E2E
Verified
Learn about vigilant mode
65555e8 
Fixes golang#60906.

Change-Id: Iba117b36041f72a54ce82cc914f8fa3b07a6fb2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/504877
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 20, 2023
@golang golang locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @findleyr